Skip to content

detailed (comparison) view: The cache misses column should be removed, invocations should be renamed #529

Closed

Description

@michaelwoerister

Since we don't record cache misses for perf.rlo, it does not make sense to show the number of cache misses (it will always be the same as the "# of invocations" right next to it).

When recording cache misses and cache hits, then invocations is hits + misses. When not recording cache hits, then invocations is misleading because it only counts the cache misses.

On zulip we settled on "full executions" as the new title for the "invocations" column. This subsumes "query provider invocations" and regular (thus uncached) function invocations.

Activity

  1. added a commit that references this issue on Dec 9, 2019
    47c576b
  2. added a commit that references this issue on Dec 19, 2019
    c7aabe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions