Skip to content

script-servo is broken again #354

Closed
Closed

Description

@nnethercote

Buried among the many warnings is this error:

error[E0599]: no method named `trace` found for type `&for<\'r> fn(&\'r dom::node::Node) -> u16` in the current scope
   --> components/script/dom/treewalker.rs:470:10
    |
470 | #[derive(JSTraceable)]
    |          ^^^^^^^^^^^
    |
    = note: JSTraceable is a function, perhaps you wish to call it
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `trace`, perhaps you need to implement it:
            candidate #1: `dom::bindings::trace::JSTraceable`

Activity

  1. SimonSapin commented on Feb 27, 2019

    @SimonSapin
    Contributor

    This sounds related to rust-lang/rust#56105. Did the breakage occur when rust-lang/rust#58592 landed?

    The fix might be adding an impl, similar to servo/servo#18327.

  2. nnethercote commented on Feb 27, 2019

    @nnethercote
    ContributorAuthor

    I removed an impl like that in #289 just last week. The conversation on IRC said the universes change was backed out, so seems like this is fallout from all that.

  3. nnethercote commented on Feb 28, 2019

    @nnethercote
    ContributorAuthor

    I pushed a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions