Add to definition of P<T> type to Appendix D: Code Index #182

Activity

1. mark-i-m

   added

   E-help-wantedCall for participation: extra help is wantedCall for participation: extra help is wanted

   E-mediumDifficulty: might require some prior knowledge or code readingDifficulty: might require some prior knowledge or code reading

   on Aug 20, 2018
2. alexreg commented on Aug 20, 2018

   

   alexreg

   on Aug 20, 2018

   ContributorAuthor

   More actions

   @eddyb's definition of it is an "immutable Box<T>". I suppose it's needed just due to the nature of tree data structures?
3. eddyb commented on Aug 20, 2018

   

   eddyb

   on Aug 20, 2018

   Contributor

   More actions

   It's not "needed", not to a large extent. The actual code has (potentially-outdated) documentation.
4. alexreg commented on Aug 20, 2018

   

   alexreg

   on Aug 20, 2018

   ContributorAuthor

   More actions

   @eddyb Well, heap allocation is surely needed, otherwise we'd have to deal with an immutable tree, and that would be very expensive during construction and later modification.
5. eddyb commented on Aug 21, 2018

   

   eddyb

   on Aug 21, 2018

   Contributor

   More actions

   I mean as a separate concept from Box or anything else.
6. mark-i-m commented on Aug 21, 2018

   

   mark-i-m

   on Aug 21, 2018

   Contributor

   More actions

   Sorry, I'm not sure I understand. We use P when we need an owned immutable pointer. We can't use &T because that is not owned and we can't use Box because it is not immutable. Is that correct?
7. alexreg commented on Aug 21, 2018

   

   alexreg

   on Aug 21, 2018

   ContributorAuthor

   More actions

   @eddyb Right, fair.

   @mark-i-m More or less, yes... @eddyb is saying that P<> doesn't really provide anything new over Box<> though – it's just a new-type with a immutability guarantee.

   👍React with 👍1Reacted by mark
8. mark-i-m

   added

   E-easyDifficulty: might be a good place for a beginnerDifficulty: might be a good place for a beginner

   and removed

   E-mediumDifficulty: might require some prior knowledge or code readingDifficulty: might require some prior knowledge or code reading

   on Aug 21, 2018
9. mark-i-m

   added a commit that references this issue on Jan 24, 2019

   fix rust-lang#182

   This issue will close once commit 259fe68 is merged into the 'master' branch.

   259fe68
10. mark-i-m

    removed

    E-help-wantedCall for participation: extra help is wantedCall for participation: extra help is wanted

    on Jan 24, 2019
11. mark-i-m

    closed this as completedin #275on Jan 24, 2019
12. mark-i-m

    added a commit that references this issue on Jan 24, 2019

    fix #182

    This issue will close once commit 658ce40 is merged into the 'main' branch.

    658ce40