Skip to content

Add #[must_use] to thread::Builder - #89789

Merged
bors merged 2 commits into
rust-lang:masterfrom
jkugelman:must-use-thread-builder
Oct 31, 2021
Merged

bors merged 2 commits into
rust-lang:masterfrom
jkugelman:must-use-thread-builder

Conversation

@jkugelman

Copy link
Copy Markdown
Contributor

I copied the wording of the fmt::Debug builders.

Affects:

std/src/thread/mod.rs:289:5   std::thread::Builder   fn new() -> Builder;
std/src/thread/mod.rs:318:5   std::thread::Builder   fn name(mut self, name: String) -> Builder;
std/src/thread/mod.rs:341:5   std::thread::Builder   fn stack_size(mut self, size: usize) -> Builder;

Parent issue: #89692

r? @joshtriplett

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2021
@the8472 the8472 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 11, 2021
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 12, 2021
Comment thread library/std/src/thread/mod.rs Resolved
@joshtriplett

Copy link
Copy Markdown
Member

There's more than one spawn function, so I made the message more generic.

Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@joshtriplett

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 30, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 6a8311c has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2021
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#89789 (Add #[must_use] to thread::Builder)
 - rust-lang#89899 (Add #[must_use] to remaining alloc functions)
 - rust-lang#90401 (hermit: Implement Condvar::wait_timeout)
 - rust-lang#90404 (hermitkernel-target: Set OS to "none")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d872d7f into rust-lang:master Oct 31, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 31, 2021
@jkugelman
jkugelman deleted the must-use-thread-builder branch October 31, 2021 02:13
@clarfonthey clarfonthey added the A-thread Area: `std::thread` label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-thread Area: `std::thread` relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants