rustc_trans: also check dominators for SSA values in mir::analyze by glandium · Pull Request #50048 · rust-lang/rust

glandium · 2018-04-18T10:03:23Z

eddyb · 2018-04-18T10:17:21Z

bors · 2018-04-18T10:17:22Z

📌 Commit a30c0f1 has been approved by eddyb

rust-highfive · 2018-04-18T10:29:01Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Resolving deltas: 100% (616766/616766), completed with 4915 local objects.
---
[00:00:52] configure: rust.quiet-tests     := True
---
[00:22:49] 219 |                         assignment_location.dominates(&location, &self.dominators)
[00:22:49]     |                                                       ^^^^^^^^^
[00:22:49]     |                                                       |
[00:22:49]     |                                                       expected struct `rustc::mir::Location`, found reference
[00:22:49]     |                                                       help: consider removing the borrow: `location`
---
[00:22:50]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_trans librustc_trans/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 --cfg feature="jemalloc" --cfg feature="rustc_back" -C metadata=3f5643aa7a2f85b9 -C extra-filename=-3f5643aa7a2f85b9 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-1299638d641ea770.rlib --extern rustc_llvm=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_llvm-4b8cacd6b6b8cbfa.rlib --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-609e2421d03f9c9a.so --extern flate2=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libflate2-3c8223b0152f22a5.rlib --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblibc-9b9c9af3e08f5b49.rlib --extern tempdir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libtempdir-65dde0349e75e965.rlib --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-c04ded78717d5d67.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-c04ded78717d5d67.rlib --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-9866e194db82a141.rlib --extern rustc_back=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_back-861dba9fe03aa669.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-3e35efb9e5bc7a9a.rlib --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-9f3518d56a01456f.so --extern rustc_mir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_mir-162a5f87ca5da25c.so --extern rustc_incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_incremental-a8b04f1fc1bbb013.so --extern rustc_demangle=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-9090c44b5d5f6a2c.rlib --extern rustc_const_math=/checkout/obj/build/x86_64-unknown-l=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-63734d0048644b22/out -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-8b35e3c2ea935fab/out/.libs -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm-72b7d72c0f85e5c7/out -L native=/usr/lib/llvm-3.9/lib` (exit code: 101)
[00:22:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/librustc_trans/Cargo.toml" "--features" " jemalloc" "--message-format" "json"
[00:22:50] expected success, got: exit code: 101
[00:22:50] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1076:9
---
[00:22:50] Makefile:28: recipe for target 'all' failed
[00:22:50] make: *** [all] Error 1

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2018-04-18T10:30:19Z

@bors r-

Fixes rust-lang#50041

glandium · 2018-04-18T11:03:31Z

Rebased and modified to fit the changes from e1f82aa.

rust-highfive · 2018-04-18T12:23:34Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:49] configure: rust.quiet-tests     := True
---
[01:02:11] .................................................................................i..................
[01:02:19] ........................i...........................................................................
---
[01:03:10] .....................i...........................................................................i..
[01:03:17] ....................................................................................................
[01:03:25] ...........ii.......................................................................................
[01:03:35] ............................................................................................i.......
---
[01:04:24] .............................................i......................................................
---
[01:09:27] ..............................i.....................................................................
[01:09:43] ...............................................................i....................................
[01:10:02] ..................................................i.................................................
[01:10:26] ....................................................................................................
[01:10:53] ....................................................................................................
[01:11:19] ............................................................F.......................................
[01:11:49] ........i...........................................................................................
[01:12:11] ....i...............................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[01:12:34] ................................................
[01:13:15] ....................................................................................................
[01:13:52] ......................................................................ii............................
[01:14:42] .................................i.........................test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[01:15:02] ...........................i.ii..........
[01:15:54] ..............................................................................................iiiiii
[01:16:28] i...................................................................................................
[01:17:06] ....................................................................................................
[01:17:43] ....................................................................................................
[01:18:41] .................................................................
[01:18:41] failures:
[01:18:41]
[01:18:41] ---- [run-pass] run-pass/mir-inlining/llvm-error-issue-50041.rs stdout ----
[01:18:41]  thread '[run-pass] run-pass/mir-inlining/llvm-error-issue-50041.rs' panicked at 'failed to exec `"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/mir-inlining/llvm-error-issue-50041.stage2-x86_64-unknown-linux-gnu"`: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', libcore/result.rs:945:5
---
[01:18:41] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:18:41] expected success, got: exit code: 101
[01:18:41]
[01:18:41]
[01:18:41] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:18:41] Build completed unsuccessfully in 0:18:11
[01:18:41] Makefile:58: recipe for target 'check' failed
[01:18:41] make: *** [check] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:31332930:start=1524054188663582763,finish=1524054188672113569,duration=8530806
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:018b483a
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:018b483a:start=1524054188680782459,finish=1524054188689021745,duration=8239286
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:129ba890
$ dmesg | grep -i kill
[   11.924288] init: failsafe main process (1096) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-04-18T13:38:57Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:44] configure: rust.quiet-tests     := True
---
[00:47:24] .................................................................................i..................
[00:47:30] ........................i...........................................................................
---
[00:48:11] .....................i...........................................................................i..
[00:48:17] ....................................................................................................
[00:48:24] ...........ii.......................................................................................
[00:48:32] ............................................................................................i.......
---
[00:49:09] .............................................i......................................................
---
[00:53:02] ..............................i.....................................................................
[00:53:15] ...............................................................i....................................
[00:53:30] .................................................i..................................................
[00:53:50] ....................................................................................................
[00:54:10] ....................................................................................................
[00:54:31] ...........................................................F........................................
[00:54:55] ........i...........................................................................................
[00:55:25] ....i....................................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:55:30] ...........
[00:56:02] ....................................................................................................
[00:56:33] ......................................................................ii............................
[00:57:24] .................................i....................................................i.ii.....test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:57:27] .....
[00:58:09] ..............................................................................................iiiiii
[00:58:37] i...................................................................................................
[00:59:08] ....................................................................................................
[00:59:34] ....................................................................................................
[00:59:51] .................................................................
[00:59:51] failures:
[00:59:51]
[00:59:51] ---- [run-pass] run-pass/mir-inlining/llvm-error-issue-50041.rs stdout ----
[00:59:51]  thread '[run-pass] run-pass/mir-inlining/llvm-error-issue-50041.rs' panicked at 'failed to exec `"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/mir-inlining/llvm-error-issue-50041.stage2-x86_64-unknown-linux-gnu"`: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', libcore/result.rs:945:5
---
[00:59:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:59:51] expected success, got: exit code: 101
[00:59:51]
[00:59:51]
[00:59:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:59:51] Build completed unsuccessfully in 0:13:44
[00:59:51] Makefile:58: recipe for target 'check' failed
[00:59:51] make: *** [check] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:103696b9:start=1524058734496489830,finish=1524058734511147672,duration=14657842
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:08c8662f
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:08c8662f:start=1524058734516594524,finish=1524058734523160523,duration=6565999
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c210964
$ dmesg | grep -i kill
[   10.864009] init: failsafe main process (1096) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2018-04-18T20:10:08Z

@bors r+

bors · 2018-04-18T20:10:09Z

📌 Commit 45fd741 has been approved by eddyb

bors · 2018-04-19T01:13:35Z

⌛ Testing commit 45fd741 with merge 5dc896e...

rustc_trans: also check dominators for SSA values in mir::analyze Fixes #50041

bors · 2018-04-19T03:53:27Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 5dc896e to master...

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 18, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2018

rustc_trans: also check dominators for SSA values in mir::analyze.

45fd741

Fixes rust-lang#50041

glandium force-pushed the issue50041 branch from a30c0f1 to d1adfa7 Compare April 18, 2018 11:02

glandium force-pushed the issue50041 branch from d1adfa7 to 80472e2 Compare April 18, 2018 12:37

glandium force-pushed the issue50041 branch from 80472e2 to 45fd741 Compare April 18, 2018 13:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2018

bors added a commit that referenced this pull request Apr 19, 2018

Auto merge of #50048 - glandium:issue50041, r=eddyb

5dc896e

rustc_trans: also check dominators for SSA values in mir::analyze Fixes #50041

bors merged commit 45fd741 into rust-lang:master Apr 19, 2018

glandium deleted the issue50041 branch April 19, 2018 07:21

Navigation Menu

Repository navigation

rustc_trans: also check dominators for SSA values in mir::analyze - #50048

rustc_trans: also check dominators for SSA values in mir::analyze#50048
bors merged 1 commit into
rust-lang:masterfrom
glandium:issue50041

glandium commented Apr 18, 2018

Uh oh!

eddyb commented Apr 18, 2018

Uh oh!

bors commented Apr 18, 2018

Uh oh!

rust-highfive commented Apr 18, 2018

Uh oh!

eddyb commented Apr 18, 2018

Uh oh!

glandium commented Apr 18, 2018

Uh oh!

rust-highfive commented Apr 18, 2018

Uh oh!

rust-highfive commented Apr 18, 2018

Uh oh!

eddyb commented Apr 18, 2018

Uh oh!

bors commented Apr 18, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

glandium commented Apr 18, 2018

Uh oh!

eddyb commented Apr 18, 2018

Uh oh!

bors commented Apr 18, 2018

Uh oh!

rust-highfive commented Apr 18, 2018

Uh oh!

eddyb commented Apr 18, 2018

Uh oh!

glandium commented Apr 18, 2018

Uh oh!

rust-highfive commented Apr 18, 2018

Uh oh!

rust-highfive commented Apr 18, 2018

Uh oh!

eddyb commented Apr 18, 2018

Uh oh!

bors commented Apr 18, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

bors commented Apr 19, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants