Repository navigation
Conversation
Collaborator
|
Some changes occurred in cfg and check-cfg configuration cc @Urgau |
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Your PR title and description have two different conditions listed. The title says |
Contributor
Author
|
Thanks, fixed. |
This comment has been minimized.
This comment has been minimized.
beetrees
force-pushed
the
data-layout-check-align
branch
from
November 1, 2026 17:42
3c15274 to
f9df966
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust requires that types have an alignment that is <= their size, so this PR checks this is the case in the data layout parser. As
i1_alignandi8_alignmust always have an alignment of 1, I've also removed those two fields fromTargetDataLayoutin the second commit and replaced any uses withAlign::ONE.