Skip to content

update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries - #163771

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
malezjaa:update-is_update-for-ipaddr
Oct 20, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
malezjaa:update-is_update-for-ipaddr

Conversation

@malezjaa

@malezjaa malezjaa commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 4, 2026
@rustbot

rustbot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from Darksonn, JohnTitor, Mark-Simulacrum, clarfonthey

@malezjaa
malezjaa force-pushed the update-is_update-for-ipaddr branch from b4a49e8 to d7f5b97 Compare October 4, 2026 22:04
@rust-log-analyzer

This comment has been minimized.

@malezjaa
malezjaa force-pushed the update-is_update-for-ipaddr branch from d7f5b97 to be1ca79 Compare October 4, 2026 22:13
@malezjaa

Copy link
Copy Markdown
Contributor Author

@rustbot reroll

@rustbot rustbot assigned JohnTitor and unassigned Mark-Simulacrum Oct 18, 2026

@JohnTitor JohnTitor left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit be1ca79 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 20, 2026
Rollup of 5 pull requests

Successful merges:

 - #164568 (Exclude MaybeDangling like types from SROA)
 - #163771 (update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries)
 - #164268 ([rustdoc]  Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc)
 - #164581 (Revert "Remove indirection for `Expr` in `Body`")
 - #164606 (triagebot: Delete the libs ad-hoc group)
@rust-bors
rust-bors Bot merged commit 2c6a2af into rust-lang:main Oct 20, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 20, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 20, 2026
Rollup merge of #163771 - malezjaa:update-is_update-for-ipaddr, r=JohnTitor

update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries

related issue: #27709

updates these methods to match IANA registires:
https://www.iana.org/assignments/iana-ipv4-special-registry
https://www.iana.org/assignments/iana-ipv6-special-registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants