Make some simple queries no longer cache on disk by compiler-errors · Pull Request #111028 · rust-lang/rust

compiler-errors · 2023-04-30T20:06:38Z

I don't think we need to cache queries with really simple local providers, like loading hir and accessing an attr

compiler-errors · 2023-04-30T20:06:57Z

bors · 2023-04-30T20:07:05Z

⌛ Trying commit 9e023dddda0034f76f60204f94a4311898e46b20 with merge 0dec5653e3ed7d09763c0fd28f3a940beee4d45b...

bors · 2023-04-30T22:22:30Z

☀️ Try build successful - checks-actions
Build commit: 0dec5653e3ed7d09763c0fd28f3a940beee4d45b (0dec5653e3ed7d09763c0fd28f3a940beee4d45b)

rust-timer · 2023-05-01T05:03:51Z

Finished benchmarking commit (0dec5653e3ed7d09763c0fd28f3a940beee4d45b): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.3%]	7
Improvements ✅ (secondary)	-0.4%	[-0.6%, -0.3%]	8
All ❌✅ (primary)	-0.2%	[-0.4%, 0.6%]	8

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.0%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-2.4%	[-2.7%, -2.1%]	5
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

compiler-errors · 2023-05-01T05:10:14Z

Once again, without codegen_fn_attrs...

@bors try @rust-timer queue

bors · 2023-05-01T05:10:22Z

⌛ Trying commit 37f7db8 with merge ca8d489ef1473f0bdd81d04fe6686ab86322b92f...

bors · 2023-05-01T06:50:58Z

☀️ Try build successful - checks-actions
Build commit: ca8d489ef1473f0bdd81d04fe6686ab86322b92f (ca8d489ef1473f0bdd81d04fe6686ab86322b92f)

bors · 2023-05-01T06:50:58Z

☀️ Try build successful - checks-actions
Build commit: ca8d489ef1473f0bdd81d04fe6686ab86322b92f (ca8d489ef1473f0bdd81d04fe6686ab86322b92f)

rust-timer · 2023-05-01T08:55:30Z

Finished benchmarking commit (ca8d489ef1473f0bdd81d04fe6686ab86322b92f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.3%]	18
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.5%]	9
All ❌✅ (primary)	-0.4%	[-0.4%, -0.3%]	18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	2.0%	[1.5%, 2.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.2%, -1.6%]	3
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.2%, -2.1%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.939s -> 655.574s (-0.21%)

compiler-errors · 2023-05-01T14:39:13Z

r? compiler

compiler-errors · 2023-05-01T14:39:38Z

r? compiler

compiler-errors · 2023-05-01T23:52:28Z

rustbot pls

r? compiler

cjgillot · 2023-05-02T17:14:47Z

@bors r+

bors · 2023-05-02T17:14:49Z

📌 Commit 37f7db8 has been approved by cjgillot

It is now in the queue for this repository.

bors · 2023-05-02T17:49:42Z

⌛ Testing commit 37f7db8 with merge a368898...

bors · 2023-05-02T21:01:44Z

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing a368898 to master...

rust-timer · 2023-05-02T23:44:51Z

Finished benchmarking commit (a368898): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.3%]	17
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.4%]	9
All ❌✅ (primary)	-0.3%	[-0.4%, -0.3%]	17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.0%, 4.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.8%, -2.6%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.2%, -1.5%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.624s -> 656.048s (-0.09%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 30, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 1, 2023

Make some simple queries no longer cache on disk

37f7db8

compiler-errors force-pushed the attr-query-no-caching branch from 9e023dd to 37f7db8 Compare May 1, 2023 05:09

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 1, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 1, 2023

compiler-errors marked this pull request as ready for review May 1, 2023 14:39

rustbot assigned cjgillot May 1, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label May 2, 2023

bors merged commit a368898 into rust-lang:master May 2, 2023

rustbot added this to the 1.71.0 milestone May 2, 2023

rustbot removed the perf-regression Performance regression. label May 2, 2023

compiler-errors deleted the attr-query-no-caching branch August 11, 2023 19:55

matthiaskrgr mentioned this pull request Aug 25, 2023

3d vector compiler bug #115203

Closed

matthiaskrgr mentioned this pull request Sep 3, 2023

ICE: unexpected bound var resolution for HirId(DefId(..)) #115497

Closed

Conversation

compiler-errors commented Apr 30, 2023

Uh oh!

compiler-errors commented Apr 30, 2023

Uh oh!

This comment has been minimized.

bors commented Apr 30, 2023

Uh oh!

bors commented Apr 30, 2023

Uh oh!

This comment has been minimized.

rust-timer commented May 1, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

compiler-errors commented May 1, 2023

Uh oh!

This comment has been minimized.

bors commented May 1, 2023

Uh oh!

bors commented May 1, 2023

Uh oh!

bors commented May 1, 2023

Uh oh!

This comment has been minimized.

rust-timer commented May 1, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

compiler-errors commented May 1, 2023

Uh oh!

compiler-errors commented May 1, 2023

Uh oh!

compiler-errors commented May 1, 2023

Uh oh!

cjgillot commented May 2, 2023

Uh oh!

bors commented May 2, 2023

Uh oh!

bors commented May 2, 2023

Uh oh!

bors commented May 2, 2023

Uh oh!

rust-timer commented May 2, 2023

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants