miri no longer builds after rust-lang/rust#93138 #93149

Activity

1. rust-highfive

   added

   A-miriArea: The miri toolArea: The miri tool

   C-bugCategory: This is a bug.Category: This is a bug.

   on Jan 21, 2022
2. rust-highfive

   assigned

   oli-obk

   ,

   eddyb

   and

   RalfJung

   on Jan 21, 2022
3. nico-abram commented on Jan 21, 2022

   

   nico-abram

   on Jan 21, 2022

   Contributor

   More actions

   I tried running tests locally against the PR's commit, seems to be failing async-fn and generator. My guess looking at the PRs in the rollup is #91032

   This is where it fails on async-fn https://github.com/rust-lang/miri/blob/9983e0fc634e11717eb457a73fe84cfc9409ba8f/tests/run-pass/async-fn.rs#L26-L41

   Here's the output:

   error: internal compiler error: compiler/rustc_mir_transform/src/generator.rs:755:13: Broken MIR: generator contains type Never in MIR, but typeck only knows about {std::future::ResumeTy, bool, u32, impl std::future::Future<Output = [async output]>, (), impl std::future::Future<Output = [async output]>} and [bool, u32]
     --> $DIR/async-fn.rs:31:53
      |
   31 |   async fn includes_never(crash: bool, x: u32) -> u32 {
      |  _____________________________________________________^
   32 | |     let mut result = async { x * x }.await;
   33 | |     if !crash {
   34 | |         return result;
   ...  |
   40 | |     result
   41 | | }
      | |_^
   
4. RalfJung commented on Jan 21, 2022

   

   RalfJung

   on Jan 21, 2022

   Member

   More actions

   Yeah the ICE reproduces outside Miri.
5. RalfJung commented on Jan 21, 2022

   

   RalfJung

   on Jan 21, 2022

   Last edited by RalfJung

   Member

   More actions

   Filed as separate bug: #93161
6. eholk commented on Jan 21, 2022

   

   eholk

   on Jan 21, 2022

   Contributor

   More actions

   I have a small PR at #93165 that should unblock this issue. I'm going to be working on a proper fix today, which I expect will be pretty quick to come up with.
7. RalfJung commented on Jan 23, 2022

   

   RalfJung

   on Jan 23, 2022

   Member

   More actions

   Fixed by #93165
8. RalfJung

   closed this as completedon Jan 23, 2022