You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is blocked on an issue with assert and debug_assert using the edition of libccore instead of the one who invoked it. (For assert only on Rust 2015 and 2018, for debug_assert on all editions.)
I tried setting core to 2021 and got this error:
Adding rustc_const_stable to panic_fmt resolved the issue but its strange that this issue didnt appear until the edition was set to 2021.
Is this another blocker? Or are we supposed to just add a rustc_const_stable?
@rust-lang/wg-const-eval: Looks like the "const-stable functions can only call other const-stable functions" check doesn't play well with #[rustc_do_not_const_check].
Activity
m-ou-se commentedon Sep 8, 2021
This is blocked on an issue with assert and debug_assert using the edition of libccore instead of the one who invoked it. (For assert only on Rust 2015 and 2018, for debug_assert on all editions.)
https://rust-lang.zulipchat.com/#narrow/stream/268952-edition-2021/topic/libcore.202021.20bug/near/252504325
camelid commentedon Sep 18, 2021
(Note that this is blocked on #88638 (comment). The bootstrap compiler is now 1.56, so that's not a blocker.)
Rollup merge of rust-lang#89622 - m-ou-se:debug-assert-2021, r=estebank
Rollup merge of rust-lang#89622 - m-ou-se:debug-assert-2021, r=estebank
Rollup merge of rust-lang#89622 - m-ou-se:debug-assert-2021, r=estebank
rukai commentedon Dec 17, 2021
I tried setting core to 2021 and got this error:
Adding rustc_const_stable to panic_fmt resolved the issue but its strange that this issue didnt appear until the edition was set to 2021.
Is this another blocker? Or are we supposed to just add a rustc_const_stable?
m-ou-se commentedon Dec 17, 2021
That's expected.
panic!("just a string")didn't use panic_fmt in Rust 2018, but does in Rust 2021. See https://doc.rust-lang.org/edition-guide/rust-2021/panic-macro-consistency.htmlm-ou-se commentedon Dec 17, 2021
@rust-lang/wg-const-eval: Looks like the "const-stable functions can only call other const-stable functions" check doesn't play well with
#[rustc_do_not_const_check].fee1-dead commentedon Dec 17, 2021
@rustbot claim
m-ou-se commentedon Dec 17, 2021
@fee1-dead what part are you claiming? The migration of core is blocked on the const check, and the migration of std is already in progress in #92030.
fee1-dead commentedon Dec 17, 2021
I will fix the const check. And since this is a tracking issue I will unclaim. Sorry for the confusion
Rollup merge of rust-lang#92030 - rukai:stdlib2021, r=m-ou-se
Rollup merge of rust-lang#92030 - rukai:stdlib2021, r=m-ou-se
Rollup merge of rust-lang#92030 - rukai:stdlib2021, r=m-ou-se