Repository navigation
Move coverage tests from run-make-fulldeps to run-make #83830
Description
I tried to do this recently and it failed. Some things to remember:
- Search for and replace references to
run-make-fulldeps - Update path to
../../run-make-fulldeps/tools.mkfrom just../tools.mk bootstraphas an explicit reference tofulldepsintest.rsto buildRustDemanglerand set--rust-demangler-path, which should be changed to support the move torun-makewithoutfulldeps
I forgot about that last one and its possible that was the only issue.
If not, check bootstrap for other fulldeps dependencies, and note that the error I thought I saw had to do with llvm-profdata or llvm-cov. If so, those may require additional special handling in bootstrap or elsewhere.
Activity
Move coverage tests from run-make-fulldeps to run-make
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
Rollup merge of rust-lang#84797 - richkadel:cover-unreachable-stateme…
richkadel commentedon May 19, 2021
Note that additional attempts to migrate coverage tests from
run-make-fulldepstorun-makedid not succeed becauserun-makeruns on some platforms that don't support LLVM coverage profiling.See PR #85007
I'm closing this issue as "Not Feasible" at this time.