"cannot produce proc-macro for crate as the target x86_64-unknown-linux-gnu does not support these crate types" with +crt-static #78210

Activity

1. rustbot

   added

   regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.Performance or correctness regression from stable to nightly.

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Oct 21, 2020
2. camelid commented on Oct 21, 2020

   

   camelid

   on Oct 21, 2020

   Member

   More actions

   Could you provide a reproduction?
3. camelid

   added

   A-proc-macrosArea: Procedural macrosArea: Procedural macros

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   on Oct 21, 2020
4. camelid commented on Oct 21, 2020

   

   camelid

   on Oct 21, 2020

   Member

   More actions

   And also the version you're testing with?
5. otavio commented on Oct 22, 2020

   

   otavio

   on Oct 22, 2020

   ContributorAuthor

   More actions

   And also the version you're testing with?

   The nightly of 2020-10-20.

   Could you provide a reproduction?

   I'm out of computer now, so I can't. It seems to be related to proc macro use. I can try to cook a test case for it.

   👍React with 👍2Reacted by Noah Lev and Jens Eckervogt
6. tesuji commented on Oct 22, 2020

   

   tesuji

   on Oct 22, 2020 · Hidden as resolved

   show commentMore actions
7. rustbot

   added

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   on Oct 22, 2020
8. JohnTitor

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   on Oct 22, 2020
9. mati865 commented on Oct 22, 2020

   

   mati865

   on Oct 22, 2020

   Member

   More actions

   It most recently worked on: rustc 1.48.0-beta.4 (fb94aa5 2020-10-20)

   It did not really work but didn't produce the error since +crt-static was no-op for linux-gnu.
   Since #77386 +crt-static now properly links statically.

   I think I can add workaround for it.
10. mati865 commented on Oct 22, 2020

    

    mati865

    on Oct 22, 2020

    Member

    More actions

    It works with explicit target:

    $ RUSTFLAGS='-C target-feature=+crt-static' cargo b
    error: cannot produce proc-macro for `ctor v0.1.16 (/tmp/rust-ctor/ctor)` as the target `x86_64-unknown-linux-gnu` does not support these crate types
    
    $ RUSTFLAGS='-C target-feature=+crt-static' cargo b --target x86_64-unknown-linux-gnu
       Compiling libc v0.2.79
       Compiling proc-macro2 v0.4.30
       Compiling unicode-xid v0.1.0
       Compiling proc-macro2 v1.0.23
       Compiling syn v0.15.44
       Compiling unicode-xid v0.2.0
       Compiling syn v1.0.46
       Compiling lazy_static v1.4.0
       Compiling quote v0.6.13
       Compiling quote v1.0.7
       Compiling libc-print v0.1.14
       Compiling dlopen_derive v0.1.4
       Compiling dlopen v0.1.8
       Compiling ctor v0.1.16 (/tmp/rust-ctor/ctor)
       Compiling tests v0.1.0 (/tmp/rust-ctor/tests)
        Finished dev [unoptimized + debuginfo] target(s) in 7.14s
    

    cc @petrochenkov I assume it's expected that #69519 helped only the case with explicit (aka cross-compiled) target?

    👍React with 👍14Reacted by Yohei Tamura, Alexei Pastuchov, Jens Eckervogt, Kirill, Matt Johnston, André-Marthin Helberg, bazizi, Lorenzo Rosa, Yang Yang, Brennan Kinney and 4 more
11. petrochenkov commented on Oct 22, 2020

    

    petrochenkov

    on Oct 22, 2020

    Last edited by petrochenkov

    Contributor

    More actions

    @mati865
    #69519 introduced different defaults for crt-static for executables (yes) and proc-macros (no) (should apply to all dylibs really).
    If -C target-feature=+crt-static is specified explicitly, then the compiler respects it and overrides the defaults, that's the compiler's job.

    Then cargo comes into play. AFAIK, it applies RUSTFLAGS only to target if --target specified explicitly, and to both target and host otherwise. (I remember people complaining about this inconsistency.)
    So it doesn't pass -C target-feature=+crt-static when compiling proc macro dependencies (which is correct in this case).
    I think this is a problem that should be solved at the cargo's abstraction level, in general. Cargo should provide a way to set compiler options per-crate-type and per-build-target (per-crate), and may provide its own defaults (e.g. not pass +crt-static to proc macro crates).

    👍React with 👍6Reacted by Mateusz Mikuła, Otavio Salvador, Josh Triplett, lafer, Alejandro González and Brennan Kinney
12. otavio commented on Oct 23, 2020

    

    otavio

    on Oct 23, 2020

    ContributorAuthor

    More actions

    My biggest concern here is this looks like a regression from the user point of view; what can we currently do to workaround it until it is handled on the cargo's abtraction level, as suggested by @petrochenkov?
13. 7 remaining items

    Load more
14. Mark-Simulacrum

    added this to the 1.48.0 milestone on Nov 6, 2020
15. Mark-Simulacrum

    added

    relnotesMarks issues that should be documented in the release notes of the next release.Marks issues that should be documented in the release notes of the next release.

    on Nov 6, 2020
16. Mark-Simulacrum commented on Nov 6, 2020

    

    Mark-Simulacrum

    on Nov 6, 2020

    Member

    More actions

    cc @XAMPPRocky for the relnotes label
17. mati865 commented on Nov 6, 2020

    

    mati865

    on Nov 6, 2020

    Member

    More actions

    The regression seems to be because we're now trying to respect the new flag, which is then causing breakage.

    @Mark-Simulacrum to be more clear, -C target-feature=+crt-static is not a new flag. It existed for a long long time but *-linux-gnu targets were ignoring it until recently.

    👍React with 👍1Reacted by Mark Rousskov
18. joshtriplett commented on Nov 15, 2020

    

    joshtriplett

    on Nov 15, 2020

    Member

    More actions

    I do think we need a better solution for building statically in general.

    Passing an explicit --target is a workaround. We should have better handling for host vs target, as @petrochenkov suggested.

    👍React with 👍9Reacted by Mike Harris, sycured, Arnau Orriols, Reilly Wood, Bryan Larsen, 小虎故洞, alex , Ricardo Fernández Serrata and Alisa Sireneva
19. joshtriplett

    changed the title [-]dynlib stopped building on nightly[/-] [+]"cannot produce proc-macro for `crate` as the target `x86_64-unknown-linux-gnu` does not support these crate types" with +crt-static[/+] on Nov 15, 2020
20. Mark-Simulacrum

    closed this as completedon Jan 21, 2021
21. Mark-Simulacrum commented on Jan 21, 2021

    

    Mark-Simulacrum

    on Jan 21, 2021

    Member

    More actions

    I don't believe we're intending to fix this.

    😕React with 😕1Reacted by Alisa Sireneva
22. Aloso commented on Apr 10, 2023

    

    Aloso

    on Apr 10, 2023

    Contributor

    More actions

    I ran into this recently. Is there a way to provide a better error message? It wasn't obvious to me that I have to pass --target x86_64-unknown-linux-gnu when I want to statically link libc.

    👍React with 👍26Reacted by PatrickChodowski, Andrew Rowson, Matt Johnston, pepa65, Dan Kov, Andrew Gunnerson, Alex Ellwein, alex , Eugene Glybin, eric-parker and 16 more
23. danieldk

    added a commit that references this issue on Jul 21, 2023

    Add target argument to test invocations

    ...

    85492a8
24. tiibun

    added a commit that references this issue on Jul 23, 2023

    fix: clap_derive on linux

    ...

    74780c9
25. lmbarros

    added a commit that references this issue on Mar 6, 2024

    Pass the build target when invoking clippy

    ...

    55ed9e7
26. Rudxain commented on Jun 17, 2024

    

    Rudxain

    on Jun 17, 2024

    Contributor

    More actions

    Now that GH supports "Closing Reasons" this should be "Closed as Not Planned"
27. loonghao

    added a commit that references this issue on Jun 29, 2025

    fix: resolve proc-macro cross-compilation issues with global RUSTFLAGS

    ...

    ddcbe43
28. egorsmkv

    added a commit that references this issue on Aug 1, 2025

    Fix an issue appeared in gh action run

    ...

    e5204fc