Skip to content

Prevent ICE on missing lang items. #72195

Closed
#72216
Closed
Prevent ICE on missing lang items.#72195
#72216
Assignees
rustbot
Labels
A-lang-itemArea: Language itemsC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@lcnr
lcnr
opened on May 14, 2020

There are currently quite a few locations in the compiler similar to the following:

rust/src/librustc_typeck/check/mod.rs

Line 5301 in 7c34d8d

let future_trait = self.tcx.lang_items().future_trait().unwrap();

This causes an internal compiler error in case the expected lang item is not defined,
for example when using #![no_core]. (see #72099)

A better way to deal with this is to use tcx.require_lang_item(FutureTraitLangItem, opt_span) instead, which cleanly stops compilation in case the lang item is missing.

See #72170, which already did this in some places.

This issue has been assigned to @DoctorN via this comment.

Activity

  1. lcnr
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on May 14, 2020
  2. jonas-schievink
    added
    A-lang-itemArea: Language items
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on May 14, 2020

  3. cofibrant commented on May 14, 2020

    @cofibrant
    cofibrant
    on May 14, 2020
    Contributor

    Ah! This is my bad...

  4. cofibrant commented on May 14, 2020

    @cofibrant
    cofibrant
    on May 14, 2020
    Contributor

    @rustbot claim

  5. rustbot
    self-assigned this
    on May 14, 2020
  6. Dylan-DPC-zz
    added 5 commits that reference this issue on May 15, 2020

    Rollup merge of rust-lang#72216 - doctorn:require-lang-item, r=lcnr

    af423c9

    Rollup merge of rust-lang#72216 - doctorn:require-lang-item, r=lcnr

    a671ffe

    Rollup merge of rust-lang#72216 - doctorn:require-lang-item, r=lcnr

    6105499

    Rollup merge of rust-lang#72216 - doctorn:require-lang-item, r=lcnr

    ccc62c8

    Rollup merge of rust-lang#72216 - doctorn:require-lang-item, r=lcnr

    1be88e6
  7. bors
    closed this as completedin 1be88e6on May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-lang-itemArea: Language itemsC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions