Repository navigation
Negative trait impl gives wrong error message #70849
Description
The following code:
#![feature(negative_impls)]
struct MyType;
impl !Clone for &mut MyType {}
fn main() {}produces:
Compiling playground v0.0.1 (/playground)
error[E0119]: conflicting implementations of trait `std::clone::Clone` for type `&mut MyType`:
--> src/main.rs:5:1
|
5 | impl !Clone for &mut MyType {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: conflicting implementation in crate `core`:
- impl<T> std::clone::Clone for &mut T
where T: ?Sized;
error: aborting due to previous error
For more information about this error, try `rustc --explain E0119`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
which reads as: any &mut T where T: ?Sized implements Clone, which isn't realy true. It realy implements !Clone.
Perhaps the error message should add a ! in front of the impl to make it more obvious, like this:
= note: conflicting implementation in crate `core`:
- impl<T> !std::clone::Clone for &mut T
where T: ?Sized;
Metadata
Metadata
Assignees
Labels
Area: Messages for errors, warnings, and lintsCategory: An issue proposing an enhancement or a PR with one.Diagnostics: A diagnostic that is giving misleading or incorrect information.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.#![feature(negative_impls)]Relevant to the compiler team, which will review and decide on the PR/issue.
Activity
heiseish commentedon Sep 11, 2024
Hi @fmease , I'd like to take up this issue if it has not been assigned yet. However this would be my first contribution so I just want to confirm it's a good first task. Thanks!
fmease commentedon Sep 12, 2024
@heiseish Yeah, for sure! It should be as simple as updating
to_pretty_impl_header(see) to account for the polarity. You can query/obtain the impl polarity withtcx.impl_polarity(impl_def_id). Feel free to reach out here or on Zulip if you have any questions.Rollup merge of rust-lang#130311 - heiseish:issue-70849-fix, r=fmease
Unrolled build for rust-lang#130311