Skip to content

test/run-make-fulldeps/pgo-branch-weights fails occasionally on CI #67746

Closed
Closed
test/run-make-fulldeps/pgo-branch-weights fails occasionally on CI#67746
Assignees
michaelwoerister
Labels
A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.P-highHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@JohnTitor
JohnTitor
opened on Dec 31, 2019

You can see this test fails occasionally in some pull requests: https://github.com/rust-lang/rust/pulls?utf8=%E2%9C%93&q=is%3Apr+pgo-branch-weights

I don't think this is due to PR changes. Could we modify, or just remove this for now?

Activity

  1. Centril
    added
    A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    I-nominated
    on Dec 31, 2019

  2. Centril commented on Dec 31, 2019

    @Centril
    Centril
    on Dec 31, 2019
    Contributor

    cc @Zoxc @michaelwoerister

  3. jonas-schievink
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    C-bugCategory: This is a bug.
    on Dec 31, 2019

  4. michaelwoerister commented on Jan 2, 2020

    @michaelwoerister
    michaelwoerister
    on Jan 2, 2020
    Member

    If the test fails, it indicates that there's a bug to be fixed. I'll try to reproduce.

  5. michaelwoerister
    self-assigned this
    on Jan 2, 2020
  6. Centril
    added
    P-highHigh priority
    on Jan 2, 2020

  7. pnkfelix commented on Jan 2, 2020

    @pnkfelix
    pnkfelix
    on Jan 2, 2020
    Contributor

    triage: P-high, removing nomination

  8. pnkfelix
    removed
    I-nominated
    on Jan 2, 2020
  9. bors
    added a commit that references this issue on Jan 3, 2020

    Auto merge of #67829 - michaelwoerister:try-to-fix-pgo-branch-weights…

    e845e69
  10. emilyalbini
    removed
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    on Jan 7, 2020

  11. michaelwoerister commented on Jan 13, 2020

    @michaelwoerister
    michaelwoerister
    on Jan 13, 2020
    Member

    Has this issue occurred since the potential fix in #67829 landed?

  12. JohnTitor commented on Jan 13, 2020

    @JohnTitor
    JohnTitor
    on Jan 13, 2020
    MemberAuthor

    I've not seen the failure recently. Should we close then?

  13. michaelwoerister commented on Jan 13, 2020

    @michaelwoerister
    michaelwoerister
    on Jan 13, 2020
    Member

    I think that's in order, yes. We can re-open if the issue re-appears.

  14. michaelwoerister
    closed this as completedon Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.P-highHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions