Cleanup: Move src/test/run-fail to src/test/ui #65440

Activity

1. Centril

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.

   A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustc

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   E-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.

   on Oct 15, 2019
2. nvlbg commented on Oct 15, 2019

   

   nvlbg

   on Oct 15, 2019

   More actions

   I'd like to work on this. First time contributor so it make take me some time to finish it.
3. Centril commented on Oct 15, 2019

   

   Centril

   on Oct 15, 2019

   ContributorAuthor

   More actions

   @rustbot assign @nvlbg
4. rustbot

   self-assigned this

   on Oct 15, 2019
5. estebank commented on Oct 15, 2019

   

   estebank

   on Oct 15, 2019

   Contributor

   More actions

   Note that some of those tests are still there due to non-determinism in the output across multiple platforms. Those should be restricted to run on only one platform to be able to do this move.
6. varkor commented on Oct 15, 2019

   

   varkor

   on Oct 15, 2019

   Contributor

   More actions

   Those should be restricted to run on only one platform to be able to do this move.

   We should make sure to cross reference these with issues too.

   👍React with 👍2Reacted by Esteban Kuber and Mazdak Farrokhzad
7. nvlbg commented on Oct 16, 2019

   

   nvlbg

   on Oct 16, 2019

   Last edited by nvlbg

   More actions

   @estebank are these tests marked somehow? Also how are tests restricted to a single platform?

   Edit: I found the following comments in the tests:

   // ignore-cloudabi no std::process
   // ignore-cloudabi no std::process
   // ignore-cloudabi no std::process
   // ignore-cloudabi no std::process
   // ignore-cloudabi no std::process
   // ignore-emscripten Needs threads
   // ignore-emscripten Needs threads.
   // ignore-emscripten Needs threads.
   // ignore-emscripten
   // ignore-emscripten
   // ignore-emscripten
   // ignore-cloudabi no std::env
   

   Are those the flags that some platforms need to be ignored?
8. estebank commented on Oct 16, 2019

   

   estebank

   on Oct 16, 2019

   Contributor

   More actions

   I believe those in particular aren't the ones u was thinking about, but they are marked with ignore- tags. I think they might be either ignore-x86 or ignore-musl, something along those lines.
9. Centril commented on Oct 16, 2019

   

   Centril

   on Oct 16, 2019

   ContributorAuthor

   More actions

   Generally speaking, a trial and error approach should work here... work through the tests a few at a time and see what will go through CI.

   👍React with 👍1Reacted by Esteban Kuber
10. JesterOrNot commented on Nov 6, 2019

    

    JesterOrNot

    on Nov 6, 2019

    More actions

    I would like to help with this

    🚀React with 🚀1Reacted by Esteban Kuber
11. RalfJung

    added a commit that references this issue on May 9, 2020

    Rollup merge of rust-lang#71185 - JohnTitor:run-fail, r=petrochenkov

    ...

    This issue will close once commit 1704dca is merged into the 'main' branch.

    1704dca
12. bors

    closed this as completedin 1704dcaon May 9, 2020