Skip to content

Don't cc rust-lang/compiler for toolstate changes #65238

Closed
#65276
Closed
Don't cc rust-lang/compiler for toolstate changes#65238
#65276
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Description

@varkor
varkor
opened on Oct 9, 2019

While it's important to keep on top of regressions to the toolstate, most of the time these issues are fixed quickly, by the author of the PR that caused the regression, or someone else. With GitHub notifications being difficult enough to keep up with as it is, being mentioned on every toolstate change issue is mostly noise. The issues are already tagged T-compiler and nominated, so I think additionally pinging everyone is unnecessary.

I think it would be sensible to change:

rust/src/tools/publish_toolstate.py

Line 146 in 5283791

cc @{}, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

to:

cc @{}, the PR reviewer, and nominating for compiler team prioritization.

cc @rust-lang/compiler

Activity

  1. jonas-schievink
    added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    on Oct 9, 2019

  2. michaelwoerister commented on Oct 9, 2019

    @michaelwoerister
    michaelwoerister
    on Oct 9, 2019
    Member

    I think that's a good idea!

  3. nikomatsakis commented on Oct 9, 2019

    @nikomatsakis
    nikomatsakis
    on Oct 9, 2019
    Contributor

    I agree that the pings are rarely useful. Nominating is probably sufficient.

  4. tmandry
    added 2 commits that reference this issue on Oct 11, 2019

    Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…

    f1d2d95

    Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…

    7ed57bb
  5. Centril
    added a commit that references this issue on Oct 11, 2019

    Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…

    d1f1cfd
  6. tmandry
    added a commit that references this issue on Oct 11, 2019

    Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…

    9917f06
  7. bors
    closed this as completedin 9917f06on Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions