Repository navigation
Lint unreachable_pub got easily confused by multiple items in a single pub use ... statement #64762
Description
This code (playground) trips unreachable_pub lint (while being completely legit).
#![deny(unreachable_pub)]
pub use self::m1::{Item1, Item2};
mod m1 {
pub use self::m2::{Item1, Item2};
mod m2 {
pub struct Item1;
pub struct Item2;
}
}However, if we break the top-level pub use ... statement into two separate statements (playground) - unreachable_pub lint convinces itself that the code is, indeed, legit.
#![deny(unreachable_pub)]
pub use self::m1::Item1;
pub use self::m1::Item2;
mod m1 {
pub use self::m2::{Item1, Item2};
mod m2 {
pub struct Item1;
pub struct Item2;
}
}Reacted by jyn, Jacob Pratt, Yosh, Evgeniy Dushistov, TehUncleDolan, Dom, Jakku Sakura, Chris Connelly and Oliver E. Anderson
Activity
[-]Lint `unreachable_pub` got easily confused by multiple items in single `pub use ...` statement[/-][+]Lint `unreachable_pub` got easily confused by multiple items in a single `pub use ...` statement[/+]jhpratt commentedon Nov 13, 2019
Running into this myself. Right now I'm just
#[allow]ing it with a link to this issue.If someone could lead me in the right direction, I'll give fixing this a shot.
197g commentedon Dec 19, 2019
It also gets confused if the export happens via a glob, also on a single item (Playground).
Added unreachable_pub lint to prevent the PlayerEvents issue from reo…
Fix PlayerEvents not being reachable from root
jyn514 commentedon Feb 28, 2020
Looks like this is because of #57922 (comment)
Fix some top-level items being missing
lambinoo commentedon Jul 11, 2021
@rustbot claim
lambinoo commentedon Jul 19, 2021
Since I claimed it 8 days ago, just a follow up.
I've been able to break the compiler a few times but I'm getting somewhere I think...
Not to a proper solution tho, just more mess, but that means more knowledge!
tl;dr: I haven't given up!
petrochenkov commentedon Jul 20, 2021
How to fix this: #82064.
Auto merge of rust-lang#87487 - lambinoo:I-64762_unreachable_pub_lint…
lambinoo commentedon Jan 10, 2022
Closed by #87487