Skip to content

Builtin macro pattern separator #63039

Closed
Closed

Description

@Undin

Since #62243 builtin macros use , as a separator between different patterns. Although, all other macros use ; instead.
Is it intended change?
This change breaks parser in IntelliJ Rust plugin. Should we adjust our parser or it should be fixed from stdlib side?

Activity

  1. Undin commented on Jul 27, 2019

    @Undin
    ContributorAuthor
  2. petrochenkov commented on Jul 27, 2019

    @petrochenkov
    Contributor

    The comma is not specific to built-in macros, but rather to unstable macro macros in general (which are currently used to define built-in macros).

    So, it's reasonable for IntelliJ to adjust its parser if it wants to support unstable code.

  3. petrochenkov commented on Jul 27, 2019

    @petrochenkov
    Contributor

    (Note that the comma itself is pretty questionable, so it's likely that it will be changed into something else, for example no separator at all, once macro macros are closer to stabilization.)

  4. Undin commented on Jul 27, 2019

    @Undin
    ContributorAuthor

    @petrochenkov Thanks for quick reply!
    Then we will adjust our parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions