Repository navigation
Tools are not available on cross compiled platforms since #61861 #62558
Copy link
Copy link
Closed
alexcrichton/rustc-auto-publish
#11Labels
A-crossArea: Cross compilationArea: Cross compilationC-bugCategory: This is a bug.Category: This is a bug.O-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateO-freebsdOperating system: FreeBSDOperating system: FreeBSDT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.Relevant to the dev-tools subteam, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.Performance or correctness regression from one stable version to another.
Description
Moved from rust-lang/rust-clippy#4267
#61861 was merged in #61962, since then Rustfmt fails to build when cross compiling which is the case for almost all non Tier 1 platforms.
Clippy and RLS are failing with similar error.
Error on aarch64-unknown-linux-gnu:
[01:14:03] error[E0464]: multiple matching crates for `rustc_macros`
[01:14:03] --> /cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-491.0.0/abi/mod.rs:10:5
[01:14:03] |
[01:14:03] | use syntax_pos::symbol::{sym, Symbol};
[01:14:03] | ^^^^^^^^^^
[01:14:03] |
[01:14:03] = note: candidates:
[01:14:03] crate `rustc_macros`: /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_macros-97bf1e9c420f9886.so
[01:14:03] crate `rustc_macros`: /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps/librustc_macros-2f4546e1163449fb.so
[01:14:03]
[01:14:03] error[E0461]: couldn't find crate `rustc_macros` with expected target triple x86_64-unknown-linux-gnu which `syntax_pos` depends on
[01:14:03] --> /cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-491.0.0/abi/mod.rs:10:5
[01:14:03] |
[01:14:03] 10 | use syntax_pos::symbol::{sym, Symbol};
[01:14:03] | ^^^^^^^^^^
[01:14:03] |
[01:14:03] = note: the following crate versions were found:
[01:14:03] crate `rustc_macros`, target triple aarch64-unknown-linux-gnu: /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/aarch64-unknown-linux-gnu/release/deps/librustc_macros-55389246a2ce204b.so
[01:14:03]
[01:14:03] error: aborting due to 2 previous errors
https://api.travis-ci.com/v3/job/209363492/log.txt
@rustbot modify labels: T-dev-tools A-rustbuild
Reacted by Mike Stipicevic, Eyal Kalderon, Frank Denis, Sergey, Christoph Groß, leo60228, Andreas Klauer, Chris West, Jonas Schievink, Jeroen Ruigrok van der Werven and 1 more
Metadata
Metadata
Assignees
Labels
A-crossArea: Cross compilationArea: Cross compilationC-bugCategory: This is a bug.Category: This is a bug.O-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateO-freebsdOperating system: FreeBSDOperating system: FreeBSDT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.Relevant to the dev-tools subteam, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.Performance or correctness regression from one stable version to another.
Activity
mati865 commentedon Jul 10, 2019
Manishearth commentedon Jul 10, 2019
Why does Clippy depend on rustfmt? We only have it in our Travis tests, and even then a test-fail shouldn't cause an unshipped tool
mati865 commentedon Jul 10, 2019
Modified issue description, it depends on
fmt_macrosbut the error is basically the same.its-pointless commentedon Jul 10, 2019
only way i got it to build cross tools was from example in original post copying librustc_macros-97bf1e9c420f9886.so over librustc_macros-2f4546e1163449fb.so
this and suddenly rust nightly std library doubling in size... fun times.
asomers commentedon Jul 29, 2019
ping. Any progress here? This issue blocks tier2 users from upgrading past rustc nightly 1.36.0.
Manishearth commentedon Jul 29, 2019
I can't tell where the logs for Clippy on cross platforms are so I don't know how to fix this. Rust has a ton of builders :/
mati865 commentedon Jul 29, 2019
@Manishearth logs for last successful merge: https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/4613/logs/937?&api-version=5.0-preview
It still fails with the same error.
Manishearth commentedon Jul 29, 2019
Hmm that seems like the rust build system being brittle. I've seen that kind of error before, it's usually solved by deleting something in the build dir.
cc @alexcrichton @pietroalbini
alexcrichton commentedon Jul 30, 2019
That isn't an issue about stale build directories or anything like that. Something is misconfigured to cause the rustc-macros crate to get built twice. The rustc_macros crate should not be getting compiled into the stage1-tools directory, but something is pulling it in. I haven't investigated to see what, though.
(it'd be good as well btw to not assume default-flakiness and instead assume that because it is a consistent regression that there's something which needs to be investigated)
mati865 commentedon Jul 30, 2019
I think
rustc_macrosare expected to be available in stage1: https://github.com/rust-lang/rust/pull/58013/files#diff-4bc384d35e57dc577b9378d4d733d7c3R818The issue started when
rustfmtwas updated and pulled new dependecy:rustc-ap-rustc_macrosin #61861martinellison commentedon Aug 21, 2019
54 remaining items
Auto merge of #4714 - msizanoen1:remove-plugin, r=Manishearth
Auto merge of #4714 - msizanoen1:remove-plugin, r=Manishearth
Auto merge of #4714 - msizanoen1:remove-plugin, r=Manishearth
Rollup merge of rust-lang#66158 - lzutao:clippyup, r=Manishearth
msizanoen1 commentedon Nov 11, 2019
Should be fixed by #66207
msizanoen1 commentedon Nov 13, 2019
The last tool, clippy is now available:
https://rust-lang.github.io/rustup-components-history/armv7-unknown-linux-gnueabihf.html
Bump the version for the following NetBSD bootstraps to 1.37.0:
Update rust to version 1.38.0.
Update rust to version 1.38.0.
Bump the version for the following NetBSD bootstraps to 1.37.0:
Update rust to version 1.38.0.
Bump the version for the following NetBSD bootstraps to 1.37.0: