The vec![..] macro can be used in pattern position with bad diagnostics

fn main() {
    match Some(vec![3]) {
        Some(vec![x]) => (),
        _ => (),
    }
}

Gives error message:

error: unexpected `(` after qualified path
 --> src/main.rs:3:14
  |
3 |         Some(vec![x]) => (),
  |              ^^^^^^^
  |              |
  |              unexpected `(` after qualified path
  |              in this macro invocation
  |
  = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

But this is clearly wrong as there is no ( in the span pointed to.

This is caused by macro expansion:

$ rustc +nightly file3.rs -Zexternal-macro-backtrace
error: unexpected `(` after qualified path
 --> <::alloc::macros::vec macros>:3:23
  |
1 | / ( $ elem : expr ; $ n : expr ) => (
2 | | $ crate :: vec :: from_elem ( $ elem , $ n ) ) ; ( $ ( $ x : expr ) , * ) => (
3 | | < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) ) ; ( $ ( $ x : expr , ) * )
  | |                       ^ unexpected `(` after qualified path
4 | | => ( $ crate :: vec ! [ $ ( $ x ) , * ] )
  | |_________________________________________- in this expansion of `vec!`
  |
 ::: file3.rs:3:14
  |
3 |           Some(vec![x]) => (),
  |                -------
  |                |
  |                in this macro invocation
  |                in this macro invocation

error: aborting due to previous error

You cannot pattern match on vectors, but you can pattern match on slices (and even rely on match ergonomics to make it look like you're matching on an array).

I think it would be nice if this was special cased since it's easily fixable.

Rollup merge of rust-lang#63399 - estebank:vec-in-pat, r=Centril

I reopened this issue (with a title update), because #80080 will reintroduce the issue (with an even odder diagnostic). While trying to come up with a way to fix this issue again with the new system, I came up with the following situation:

Add a way to mark macro_rules declarations with an attribute that declares what their returned AST node type is. Then we mark macro_rules! vec as only producing expressions and add a check during expansion that handles this and reports errors if used wrongly. This will always produce the right error, and we can then also re-add a suggestion if vec! specifically has been used in pattern position.

@oli-obk

I think that's a reasonable solution. Do you want to cut a PR for it and deleting the now unused code, @oli-obk?

I'll write up instructions and hope that someone will pick it up as a good first issue over the holidays. If not, I'll do it before #80080 gets merged.

write @rustbot claim in this issue to assign it to yourself
cherry pick 5e0401f to remove the old code
change the vec! macro in https://github.com/rust-lang/rust/blob/master/library/alloc/src/macros.rs#L41-L51 to the one shown above
leave some documentation on the force_expr_internal_do_not_use macro arm explaining that it is to force the ast node type to an expression, thus improving the diagnostics if used in type or pattern position
Run ./x.py test src/tests/ui --bless which auto-updates all .stderr files and update all //~ ERROR and other comments that need updating (likely you'll be able to remove some of them entirely because we now only get a single error
open a PR (also do that if you get stuck or anything doesn't work) and write r? @oli-obk in the main message so it gets assigned to me

@rustbot

@rustbot claim

Rollup merge of rust-lang#81080 - bugadani:vec-diag, r=oli-obk,m-ou-se

Remove `__rust_force_expr`.

Rollup merge of rust-lang#126929 - nnethercote:rm-__rust_force_expr, …

Unrolled build for rust-lang#126929

Navigation Menu

Repository navigation

The `vec![..]` macro can be used in pattern position with bad diagnostics #61933

1 remaining item

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

The vec![..] macro can be used in pattern position with bad diagnostics #61933

Description

Activity

estebank commented on Jun 18, 2019

czipperz commented on Jun 23, 2019

oli-obk commented on Dec 18, 2020

1 remaining item

estebank commented on Dec 18, 2020

oli-obk commented on Dec 19, 2020

bugadani commented on Jan 16, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

The `vec![..]` macro can be used in pattern position with bad diagnostics #61933