Use of raw RWLock instead of RwLock

@rustbot

Lines 57 to 58 in 7ac0200

    
           static HOOK_LOCK: RWLock = RWLock::new(); 
        
           static mut HOOK: Hook = Hook::Default;

looking at these two lines of code is very frightening.
Is there a specific reason to use RWLock instead of RwLock? I would open a PR with either using RwLock or a comment describing why RWLock is needed here.

@rustbot modify labels: T-libs

Just another thought, isn't the naming itself a bit dangerous? RW vs. Rw seems like an easy typo to make. Perhaps renaming RW as RawRw could help?

RwLock can't be statically initialized, or at least couldn't be when that code was written. That'll change once the parking_lot PR lands.

@sfackler

Hey @sfackler
has the parking_lot PR already landed? Can you maybe tell the PR number? I would like to give it a shot to clean this up.

It was not merged: #56410 (comment)

I will close this issue as I don't see that this can and will be addressed any time soon. Thank you for your answer mati :)

Navigation Menu

Repository navigation

Use of raw RWLock instead of RwLock #60576

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	static HOOK_LOCK: RWLock = RWLock::new();
	static mut HOOK: Hook = Hook::Default;

Use of raw RWLock instead of RwLock #60576

Description

Activity

Lonami commented on May 6, 2019

sfackler commented on May 6, 2019

hellow554 commented on May 25, 2021

mati865 commented on May 25, 2021

hellow554 commented on May 25, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions