Overflowing literal lint is silenced in range literals in loops on nightly #60459

Activity

1. varkor

   added

   A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.

   on May 1, 2019
2. varkor

   self-assigned this

   on May 1, 2019
3. varkor commented on May 1, 2019

   

   varkor

   on May 1, 2019

   ContributorAuthor

   More actions

   It is hitting the err.emit() here:
   

   rust/src/librustc_lint/types.rs

   Line 102 in 9b67bd4

   err.emit();

   
   So I'm not quite sure why the error isn't being emitted yet.
4. jonas-schievink

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on May 2, 2019
5. ehuss commented on May 2, 2019

   

   ehuss

   on May 2, 2019

   Contributor

   More actions

   It appears to be hitting this line of code which is cancelling the diagnostic:

   rust/src/librustc/lint/mod.rs

   Line 746 in d15fc17

   err.cancel()
6. pnkfelix commented on May 23, 2019

   

   pnkfelix

   on May 23, 2019

   Contributor

   More actions

   this appears to be a stable-to-beta regression (playpen)
7. pnkfelix commented on May 23, 2019

   

   pnkfelix

   on May 23, 2019

   Contributor

   More actions

   triage: P-high. Assigning to self.
8. pnkfelix

   self-assigned this

   on May 23, 2019
9. pnkfelix

   added

   P-highHigh priorityHigh priority

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   on May 23, 2019
10. estebank commented on May 23, 2019

    

    estebank

    on May 23, 2019

    Contributor

    More actions

    We need to change

    rust/src/librustc/lint/mod.rs

    Line 871 in d15fc17

    ExpnFormat::CompilerDesugaring(_) => return true, // well, it's "external"

    to not consider desugarings coming from for loops as external. If that has regressions in our test suite, then we can add a new desugaring kind to differentiate between different parts of the for loop desugaring and target it further, but I do not expect that to be needed.

    👍React with 👍1Reacted by varkor
11. varkor commented on May 23, 2019

    

    varkor

    on May 23, 2019

    ContributorAuthor

    More actions

    @pnkfelix: I've opened #61098 with a fix, based on @estebank's comment.
12. Centril

    added a commit that references this issue on May 23, 2019

    Rollup merge of rust-lang#61098 - varkor:fix-overflowing-literal-in-l…

    ...

    92fda92
13. bors

    closed this as completedin #61098on May 24, 2019