Stabilize the core::array module and reexport in std (for TryFromSliceError) #60014

Activity

1. jonas-schievink

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.Relevant to the release subteam, which will review and decide on the PR/issue.

   on Apr 16, 2019
2. jonas-schievink commented on Apr 16, 2019

   

   jonas-schievink

   on Apr 16, 2019

   Contributor

   More actions

   cc @rust-lang/release another missed libstd reexport
3. jonas-schievink

   added

   I-nominated

   on Apr 16, 2019
4. Mark-Simulacrum

   added

   stable-acceptedAccepted for backporting to the compiler in the stable channel.Accepted for backporting to the compiler in the stable channel.

   stable-nominatedNominated for backporting to the compiler in the stable channel.Nominated for backporting to the compiler in the stable channel.

   and removed

   stable-acceptedAccepted for backporting to the compiler in the stable channel.Accepted for backporting to the compiler in the stable channel.

   on Apr 16, 2019
5. Centril commented on Apr 16, 2019

   

   Centril

   on Apr 16, 2019

   Contributor

   More actions

   Can @rust-lang/libs confirm that you wish to stabilize TryFromSliceError in core::array?
6. alexcrichton commented on Apr 17, 2019

   

   alexcrichton

   on Apr 17, 2019

   Member

   More actions

   I suspect that we want this type stable but probably not in core::array but rather in {core,std,alloc}::slice.
7. SimonSapin

   added

   beta-acceptedAccepted for backporting to the compiler in the beta channel.Accepted for backporting to the compiler in the beta channel.

   and removed

   T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.Relevant to the release subteam, which will review and decide on the PR/issue.

   stable-nominatedNominated for backporting to the compiler in the stable channel.Nominated for backporting to the compiler in the stable channel.

   on Apr 17, 2019
8. SimonSapin

   changed the title [-]TryFromSliceError is only available in core::array which is unstable[/-] [+]Stabilize the core::array module and reexport in std (for TryFromSliceError)[/+] on Apr 17, 2019
9. SimonSapin commented on Apr 17, 2019

   

   SimonSapin

   on Apr 17, 2019

   Last edited by SimonSapin

   Contributor

   More actions

   The libs team discussed this in today’s triage meeting. std::slice was suggested as an alternative location for this type, but David pointed out that array::TryFromSliceError reads better than slice::TryFromSliceError. Additionally, we expect to have more array-related APIs (e.g. iterator types) in the future. So consensus was to stabilize the array module and reexport it in std.

   We feel comfortable backporting this to beta, but backporting to stable and mentioning this in a point release blog post seems excessive. This error type is part of another of a return type in another API and typically does not need to be named.

   Since std::array hasn’t been formally proposed before, let’s do the process dance:

   @rfcbot fcp merge
10. rfcbot commented on Apr 17, 2019

    

    rfcbot

    on Apr 17, 2019

    Last edited by Amanieu

    More actions

    Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

    • @Amanieu
    • @Kimundi
    • @SimonSapin
    • @alexcrichton
    • @dtolnay
    • @sfackler
    • @withoutboats

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.
11. rfcbot

    added

    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.

    on Apr 17, 2019
12. alexcrichton

    removed

    I-nominated

    on Apr 18, 2019
13. rfcbot

    added

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    on Apr 29, 2019
14. rfcbot commented on Apr 29, 2019

    

    rfcbot

    on Apr 29, 2019

    More actions

    🔔 This is now entering its final comment period, as per the review above. 🔔
15. rfcbot

    removed

    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

    on Apr 29, 2019
16. rfcbot

    added

    finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.

    on May 9, 2019
17. rfcbot commented on May 9, 2019

    

    rfcbot

    on May 9, 2019

    More actions

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    The RFC will be merged soon.
18. rfcbot

    removed

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    on May 9, 2019
19. Centril

    added a commit that references this issue on May 9, 2019

    Rollup merge of rust-lang#60657 - JohnTitor:stabilize-array, r=SimonS…

    ...

    This issue will close once commit e40f9a6 is merged into the 'master' branch.

    e40f9a6
20. bors

    closed this as completedin e40f9a6on May 9, 2019