Skip to content

region tests incorrectly passing with NLL enabled #56993

Closed

Description

@nikomatsakis

The following tests pass under NLL, but ought not to (in some cases, light editing is required to observe that):

To observe the problems, though, you need to run in true NLL mode (i.e., #![feature(nll)] or -Zborrowck=mir). In migration mode, the lexical borrow checker still reports the errors in question.

Activity

  1. added
    A-NLLArea: Non-lexical lifetimes (NLL)
    NLL-soundWorking towards the "invalid code does not compile" goal
    on Dec 19, 2018
  2. self-assigned this
    on Dec 19, 2018
  3. matthewjasper commented on Dec 22, 2018

    @matthewjasper
    Contributor

    This appear to have regressed between nightly-2018-10-24 and nightly-2018-10-26.

    #55323 looks suspicious

  4. added a commit that references this issue on Jan 25, 2019
  5. matthewjasper commented on Jan 25, 2019

    @matthewjasper
    Contributor

    These tests are now properly tested with NLL enabled using revisions. Once migrate mode is the default we can switch compare mode to use -Zborrowck=mir and close this issue.

  6. added
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    on Mar 27, 2019
  7. added 3 commits that reference this issue on Apr 22, 2019
  8. added a commit that references this issue on May 17, 2019
    b982867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A-NLLArea: Non-lexical lifetimes (NLL)E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.NLL-soundWorking towards the "invalid code does not compile" goalP-mediumMedium priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions