Skip to content

Schouldn't File::sync_all uselibc::fcntl(fd, libc::F_FULLFSYNC) on macos/ios #55920

Closed
Closed
Schouldn't File::sync_all uselibc::fcntl(fd, libc::F_FULLFSYNC) on macos/ios#55920
Labels
O-iosOperating system: iOSO-macosOperating system: macOST-libs-api[DEPRECATED; DO NOT USE]

Description

@rustonaut
rustonaut
opened on Nov 13, 2018

As far as I know fsync doens't sync data onto disk on macos.
(Depending on kernel & file system it might not do so on linux either).

Which is why sync_data does use fcntl on mac for sync_data
and sync_all implies syncing data, so shouldn't it use fcntl, too?

Activity

  1. nagisa
    added
    T-libs-api[DEPRECATED; DO NOT USE]
    O-macosOperating system: macOS
    O-iosOperating system: iOS
    on Nov 17, 2018
  2. davazp
    added a commit that references this issue on Apr 19, 2019

    Fix sync_all on macos/ios

    d602a6b
  3. bors
    closed this as completedin d602a6bon Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-iosOperating system: iOSO-macosOperating system: macOST-libs-api[DEPRECATED; DO NOT USE]

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions