Skip to content

Add riscv64imac_unknown_none_elf support #53308

Closed
Closed
Add riscv64imac_unknown_none_elf support#53308
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.O-riscvTarget: RISC-V architectureT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@ingenieroariel
ingenieroariel
opened on Aug 13, 2018

#52787 added support only for riscv32imac_unknown_none_elf.

I am working on riscv64imac_unknown_none_elf soft cores (running sel4) and would love to be able to use Rust, in particular: https://github.com/PolySync/cargo-fel4

I don't know the domain yet but would love to learn by going through the PR submission process to add that architecture if there are no reasons to exclude it. Are there reasons for not including riscv64imac related to hardware in the wild?

/cc @japaric

Activity

  1. hanna-kruppe commented on Aug 13, 2018

    @hanna-kruppe
    hanna-kruppe
    on Aug 13, 2018
    Contributor

    RV64 support in LLVM is practically nil at this point, so we can't just generate code for it yet.

  2. lachlansneff commented on Aug 13, 2018

    @lachlansneff
    lachlansneff
    on Aug 13, 2018

    Yeah, the riscv port of nebulet is waiting on support for riscv64 (as well as its various extensions).

  3. memoryruins commented on Nov 4, 2018

    @memoryruins
    memoryruins
    on Nov 4, 2018
    Contributor

    I'm really excited to see interest in RV64 support in Rust and I'm keen to do what I can to support you in this. The immediate priority is pretty clear - get these patches merged upstream. Beyond that, please keep tagging me in issues that I can help with and of course file bug reports on bugs.llvm.org when appropriate.

    rust-embedded/wg#218 (comment)

  4. tarcieri commented on Nov 30, 2018

    @tarcieri
    tarcieri
    on Nov 30, 2018
    Contributor

    I'm very much interested in this as well (for use on the HiFive Unleashed)

  5. fintelia commented on Jan 26, 2019

    @fintelia
    fintelia
    on Jan 26, 2019
    Contributor

    Have the relevant patches been merged at this point?

  6. memoryruins commented on Jan 26, 2019

    @memoryruins
    memoryruins
    on Jan 26, 2019
    Contributor

    Wow, nearly all the patches have been merged to LLVM by now.
    Posted an update in rust-embedded/wg#218 (comment)

  7. jonas-schievink
    added
    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 27, 2019
  8. nagisa
    added
    O-riscvTarget: RISC-V architecture
    on Jan 27, 2019

  9. davidlt commented on Jan 30, 2019

    @davidlt
    davidlt
    on Jan 30, 2019

    I would expect to see RV64GC support within the next LLVM release. Note, that Linux distributions target RV64GC.

  10. Disasm commented on Feb 17, 2019

    @Disasm
    Disasm
    on Feb 17, 2019
    Contributor

    I hope we can close the issue: riscv64imac-unknown-none-elf and riscv64gc-unknown-none-elf targets are already in nightly. Read here about some cautions: rust-embedded/wg#218 (comment)

  11. ingenieroariel commented on Feb 18, 2019

    @ingenieroariel
    ingenieroariel
    on Feb 18, 2019
    Author

    Closing, thanks!

  12. ingenieroariel
    closed this as completedon Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.O-riscvTarget: RISC-V architectureT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions