ICE "Tried to access element 1 of array/slice with length 0" (librustc_mir) / const_eval / collect_and_partition_mono_items #53275

Activity

1. ralfbiedert commented on Aug 11, 2018

   

   ralfbiedert

   on Aug 11, 2018

   ContributorAuthor

   More actions

   The error reproduces on Travis:

   https://travis-ci.org/ralfbiedert/ffsvm-rust/builds/414946306
2. ralfbiedert commented on Aug 11, 2018

   

   ralfbiedert

   on Aug 11, 2018

   ContributorAuthor

   More actions

   Minimal changes needed to trigger / prevent ICE:

   ralfbiedert/ffsvm@344c31f (no ICE)
   ralfbiedert/ffsvm@bee2842 (ICE)
3. estebank

   added

   I-ICEIssue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️

   A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html

   on Aug 12, 2018
4. jonas-schievink

   added

   A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)Area: Constant evaluation, covers all const contexts (static, const fn, ...)

   C-bugCategory: This is a bug.Category: This is a bug.

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on Aug 6, 2019
5. oli-obk

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   on Dec 20, 2019
6. oli-obk commented on Dec 20, 2019

   

   oli-obk

   on Dec 20, 2019

   Contributor

   More actions

   It would be great if someone could test this on a recent rustc and if it still fails, try to minimize it
7. ralfbiedert commented on Dec 20, 2019

   

   ralfbiedert

   on Dec 20, 2019

   ContributorAuthor

   More actions

   I had to update a few files to make it "compile" again, but I still get an ICE with a recent rustc 1.41.0-nightly (c8ea4ace9 2019-12-14):

   thread 'rustc' panicked at 'assertion failed: `(left == right)`
     left: `4`,
    right: `0`', src\librustc\mir\interpret\value.rs:305:17
   stack backtrace:
      0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
      1: core::fmt::write
      2: <std::io::IoSliceMut as core::fmt::Debug>::fmt
      3: std::panicking::take_hook
      4: std::panicking::take_hook
      5: rustc_driver::report_ice
      6: std::panicking::rust_panic_with_hook
      7: rust_begin_unwind
      8: std::panicking::begin_panic_fmt
      9: <rustc_mir::shim::CallKind as core::fmt::Debug>::fmt
     10: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     11: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     12: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     13: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     14: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     15: rustc_mir::const_eval::const_eval_raw_provider
     16: <rustc_mir::build::ScopeId as core::fmt::Debug>::fmt
     17: <rustc_mir::shim::CallKind as core::fmt::Debug>::fmt
     18: <rustc_mir::hair::pattern::PatRange as core::fmt::Debug>::fmt
     19: <rustc_mir::shim::CallKind as core::fmt::Debug>::fmt
     20: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     21: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     22: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     23: <rustc_mir::transform::remove_noop_landing_pads::RemoveNoopLandingPads as rustc_mir::transform::MirPass>::run_pass
     24: <rustc_mir::transform::const_prop::ConstPropagator as rustc::mir::visit::MutVisitor>::visit_statement
     25: <rustc_mir::transform::const_prop::ConstProp as rustc_mir::transform::MirPass>::run_pass
     26: rustc_mir::transform::run_passes
     27: rustc_mir::transform::run_passes
     28: rustc_mir::transform::run_passes
     29: rustc::middle::weak_lang_items::<impl rustc::ty::context::TyCtxt>::is_weak_lang_item
     30: rustc::dep_graph::graph::DepGraph::assert_ignored
     31: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::try_print_query_stack
     32: rustc::ty::<impl rustc::ty::context::TyCtxt>::instance_mir
     33: rustc_mir::monomorphize::collector::collect_crate_mono_items
     34: rustc_mir::monomorphize::collector::collect_crate_mono_items
     35: rustc_mir::monomorphize::collector::collect_crate_mono_items
     36: <rustc_mir::transform::const_prop::ConstPropagator as rustc::mir::visit::MutVisitor>::visit_terminator
     37: <rustc_mir::interpret::memory::AllocCheck as core::fmt::Debug>::fmt
     38: rustc_mir::monomorphize::collector::collect_crate_mono_items
     39: <rustc_mir::interpret::memory::AllocCheck as core::fmt::Debug>::fmt
     40: rustc_mir::monomorphize::partitioning::compute_codegen_unit_name
     41: <rustc_codegen_llvm::llvm_::archive_ro::Iter as core::ops::drop::Drop>::drop
     42: <rustc_codegen_llvm::back::lto::ThinLTOImports as core::fmt::Debug>::fmt
     43: rustc_codegen_llvm::llvm_::diagnostic::Diagnostic::unpack
     44: <rustc_codegen_llvm::llvm_::ffi::PassKind as core::fmt::Debug>::fmt
     45: <rustc_codegen_llvm::LlvmCodegenBackend as rustc_codegen_utils::codegen_backend::CodegenBackend>::codegen_crate
     46: rustc_interface::passes::QueryContext::print_stats
     47: rustc_interface::passes::QueryContext::print_stats
     48: <env_logger::filter::inner::Filter as core::fmt::Debug>::fmt
     49: rustc_interface::queries::Queries::ongoing_codegen
     50: rustc_driver::pretty::print_after_hir_lowering
     51: <syntax_pos::symbol::SymbolStr as core::fmt::Display>::fmt
     52: <rustc::hir::Expr as rustc_typeck::check::coercion::AsCoercionSite>::as_coercion_site
     53: <rustc_driver::Compilation as core::fmt::Debug>::fmt
     54: <rustc_driver::Compilation as core::fmt::Debug>::fmt
     55: _rust_maybe_catch_panic
     56: rustc_driver::pretty::print_after_hir_lowering
     57: ZN244_$LT$std..error..$LT$impl$u20$core..convert..From$LT$alloc..string..String$GT$$u20$for$u20$alloc..boxed..Box$LT$dyn$u20$std..error..Error$u2b$core..marker..Sync$u2b$core..marker..Send$GT$$GT$..from..StringError$u20$as$u20$core..fmt..Display$GT$3fmt17
     58: std::sys::windows::thread::Thread::new
     59: BaseThreadInitThunk
     60: RtlUserThreadStart
   note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
   
   error: internal compiler error: unexpected panic
   
   note: the compiler unexpectedly panicked. this is a bug.
   
   note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
   
   note: rustc 1.41.0-nightly (c8ea4ace9 2019-12-14) running on x86_64-pc-windows-msvc
   
   note: compiler flags: -C debuginfo=2 -C incremental
   
   note: some of the compiler flags provided by cargo are hidden
   
   query stack during panic:
   #0 [const_eval_raw] const-evaluating `svm_class::m_csvm_linear`
   #1 [optimized_mir] processing `svm_class::m_csvm_linear`
   #2 [collect_and_partition_mono_items] collect_and_partition_mono_items
   end of query stack
   error: aborting due to previous error
   
   error: could not compile `ffsvm`.
   
   Caused by:
     process didn't exit successfully: `rustc --edition=2018 --crate-name svm_class tests\svm_class.rs --error-format=json --json=diagnostic-rendered-ansi --emit=dep-info,link -C debuginfo=2 --test -C metadata=4ed02486dfc162c8 -C extra-filename=-4ed02486dfc162c8 --out-dir D:\Development\Source\ffsvm-rust\target\debug\deps -C incremental=D:\Development\Source\ffsvm-rust\target\debug\incremental -L dependency=D:\Development\Source\ffsvm-rust\target\debug\deps --extern ffsvm=D:\Development\Source\ffsvm-rust\target\debug\deps\libffsvm-526e738465434a2b.rlib --extern packed_simd=D:\Development\Source\ffsvm-rust\target\debug\deps\libpacked_simd-6600a16e46b39a24.rlib --extern pest=D:\Development\Source\ffsvm-rust\target\debug\deps\libpest-4cd557cf2fa26b5a.rlib --extern pest_derive=D:\Development\Source\ffsvm-rust\target\debug\deps\pest_derive-1fd69ab1b51bb5e5.dll --extern rand=D:\Development\Source\ffsvm-rust\target\debug\deps\librand-b0b96e83c985670f.rlib --extern simd_aligned=D:\Development\Source\ffsvm-rust\target\debug\deps\libsimd_aligned-56341438da1a9b6a.rlib` (exit code: 101)
   
8. oli-obk commented on Dec 20, 2019

   

   oli-obk

   on Dec 20, 2019

   Contributor

   More actions

   Awesome! thanks for the quick work.
9. oli-obk

   removed

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   on Dec 21, 2019
10. Centril commented on Mar 10, 2020

    

    Centril

    on Mar 10, 2020

    Contributor

    More actions

    @ralfbiedert Do you think you could reduce this further?
11. ralfbiedert commented on Mar 10, 2020

    

    ralfbiedert

    on Mar 10, 2020

    ContributorAuthor

    More actions

    I just tried to reproduce this once more with rustc 1.43.0-nightly (564758c4c 2020-03-08) and instead of an ICE it now produces multiple compilation errors, such as:

      --> tests\svm_class.rs:90:5
       |
    90 |     test_model!(m_nusvm_poly, "m_nusvm_poly.libsvm", false, [0, 7], []);
       |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ referenced constant has errors
       |
       = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
    
    error: this operation will panic at runtime
      --> tests\svm_class.rs:50:38
       |
    50 |                     SVMResult::Label($libsvm_prob[0]),
       |                                      ^^^^^^^^^^^^^^^ index out of bounds: the len is 0 but the index is 0
    ...
    91 |     test_model!(m_nusvm_rbf, "m_nusvm_rbf.libsvm", false, [0, 7], []);
       |     ------------------------------------------------------------------ in this macro invocation
       |
       = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
    
    error: reaching this expression at runtime will panic or abort
      --> tests\svm_class.rs:50:38
       |
    50 |                     SVMResult::Label($libsvm_prob[0]),
       |                                      ^^^^^^^^^^^^^^^ indexing out of bounds: the len is 0 but the index is 0
    ...
    91 |     test_model!(m_nusvm_rbf, "m_nusvm_rbf.libsvm", false, [0, 7], []);
       |     ------------------------------------------------------------------
       |     |
       |     in this macro invocation
       |
       = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
    

    This pretty much seems to "prevent" how I could previously ICE it, enabling or disabling macro invocations with an empty array that then got accessed:

    // ENABLING THIS LINE TRIGGERS IT:
    test_model!(m_csvm_linear, "m_csvm_linear.libsvm", false, [0, 7], []);

    Seems like this got fixed.

    On a side note, I'm positively surprised it detects this will panic at runtime, although one could make the argument that maybe I wanted that macro expansion to panic inside a #[should_panic] unit test, and therefore emitting a compilation error is too strong.

    (Update) Hm, strangely enough, the error generation is only triggered when running cargo test, not when running cargo check (even if I move the invalid array access into the main library). It still doesn't ICE, but it also doesn't produce the errors.
12. Centril

    added

    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

    on Mar 10, 2020
13. Centril commented on Mar 10, 2020

    

    Centril

    on Mar 10, 2020

    Contributor

    More actions

    Cool; ideally, if we could create a minimal example that we could add as a regression test that would be great, and if not, then I guess we'll close the issue as it no longer ICEs.
14. ralfbiedert commented on Mar 10, 2020

    

    ralfbiedert

    on Mar 10, 2020

    Last edited by ralfbiedert

    ContributorAuthor

    More actions

    Alright, here is the MVP that would do it:

    // src/lib.rs
    
    struct S(u8);
    
    pub fn ice() {
        S([][0]);
    }

    When I run this with cargo build on 1.41.0-nightly (6d77e45f0 2019-12-04) it would ICE as above; with the latest rustc 1.43.0-nightly (564758c4c 2020-03-08) it just gives an error.

    ❤️React with ❤️1Reacted by Yuki Okushi
15. Centril

    removed

    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

    on Mar 14, 2020
16. Centril commented on Mar 14, 2020

    

    Centril

    on Mar 14, 2020

    Contributor

    More actions

    Thanks, cc @JohnTitor

    👍React with 👍1Reacted by Yuki Okushi
17. rylev

    added a commit that references this issue on Mar 20, 2020

    Add test for issue rust-lang#53275

    f1188f7
18. Centril

    added 2 commits that reference this issue on Mar 23, 2020

    Rollup merge of rust-lang#70195 - rylev:test-for-53275, r=Centril

    ...

    4be1ec1

    Rollup merge of rust-lang#70195 - rylev:test-for-53275, r=Centril

    ...

    ad6d303
19. bors

    added a commit that references this issue on Mar 23, 2020

    Auto merge of rust-lang#70330 - Centril:rollup-ts0clvx, r=Centril

    ...

    1edd389
20. bors

    closed this as completedin ad6d303on Mar 23, 2020