nll: incorrect unused-mut warnings #51918

Activity

1. nikomatsakis

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   WG-compiler-nll

   NLL-completeWorking towards the "valid code works" goalWorking towards the "valid code works" goal

   on Jun 29, 2018
2. nikomatsakis

   added this to the Rust 2018 Preview 2 milestone on Jun 29, 2018
3. matthewjasper commented on Jun 29, 2018

   

   matthewjasper

   on Jun 29, 2018

   Contributor

   More actions

   There are at least two different issues here it seems:

   fn foo(ref x: i32) {}
   
   fn bar() {
       let mut x = 0;
       move || {
           x = 1;
       };
   }

   I'll try to have a PR for the first one over the weekend.
   The second one requires move investigation, because the code is certainly trying to avoid linting in this case.

   👍React with 👍1Reacted by Rémy Rakic
4. matthewjasper

   assigned

   matthewjasper

   and unassigned

   matthewjasper

   on Jul 1, 2018
5. jkordish

   added

   C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.

   A-NLLArea: Non-lexical lifetimes (NLL)Area: Non-lexical lifetimes (NLL)

   on Jul 3, 2018
6. bors

   added a commit that references this issue on Jul 5, 2018

   Auto merge of #51964 - matthewjasper:unused-mut-mir-generation, r=nik…

   ...

   b51ca20
7. nikomatsakis commented on Jul 6, 2018

   

   nikomatsakis

   on Jul 6, 2018

   ContributorAuthor

   More actions

   @matthewjasper what remains now that your PR landed?
8. matthewjasper commented on Jul 6, 2018

   

   matthewjasper

   on Jul 6, 2018

   Contributor

   More actions

   I don't think there are any more bugs. I think this is just waiting for this to be on nightly a few days to be sure.
9. nikomatsakis commented on Jul 17, 2018

   

   nikomatsakis

   on Jul 17, 2018

   ContributorAuthor

   More actions

   Closing as fixed then. @matthewjasper let me know if you think that's wrong!

   👍React with 👍1Reacted by matthewjasper
10. nikomatsakis

    closed this as completedon Jul 17, 2018