Rename CodeMap/FileMap to SourceMap/SourceFile. #51574

Activity

1. eddyb

   added

   C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.

   on Jun 15, 2018
2. Mark-Simulacrum

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   on Jun 15, 2018
3. abhijeetbhagat commented on Jun 15, 2018

   

   abhijeetbhagat

   on Jun 15, 2018

   Contributor

   More actions

   I can take this up.

   🎉React with 🎉1Reacted by Eduard-Mihai Burtescu
4. abhijeetbhagat commented on Jun 22, 2018

   

   abhijeetbhagat

   on Jun 22, 2018

   Contributor

   More actions

   What about structs like FileMapAndLine ?
5. eddyb commented on Jun 22, 2018

   

   eddyb

   on Jun 22, 2018

   ContributorAuthor

   More actions

   @abhijeetbhagat SourceFileAndLine looks fine to me.
6. dsciarra commented on Jul 30, 2018

   

   dsciarra

   on Jul 30, 2018

   Contributor

   More actions

   should the module codemap also be renamed?
7. eddyb commented on Jul 30, 2018

   

   eddyb

   on Jul 30, 2018

   ContributorAuthor

   More actions

   Yeah, any combination of the words "code" and "map" should.
8. abhijeetbhagat commented on Jul 31, 2018

   

   abhijeetbhagat

   on Jul 31, 2018

   Contributor

   More actions

   Right. Changing that too.
9. bors

   added a commit that references this issue on Aug 19, 2018

   Auto merge of #52953 - dsciarra:mv-codemap-sourcemap, r=petrochenkov

   ...

   6bf6d50
10. jolson88 commented on Oct 6, 2018

    

    jolson88

    on Oct 6, 2018

    Contributor

    More actions

    With the merge, it's unclear to me whether this is an older issue that needs closing, or if there is more work to do. A quick search seems to show the following occurences still:

    • MalformedForCodemap and MalformedCodemapPositions in src/libsyntax_pos/lib.rs and src/libsyntax/source_map.rs
    • pub use self::caching_codemap_view::CachingSourceMapView in src/librustc/ich/mod.rs
    • StableFilemapId in src/libsyntax/source_map.rs

    If this issue is still considered open, does that reflect that that these should be renamed as well?

    • MalformedForCodemap -> MalformedForSourceMap
    • MalformedCodemapPositions -> MalformedSourceMapPositions
    • self::caching_codemap_view -> self::caching_source_map_view
    • StableFilemapId -> StableSourceFileId

    👍React with 👍1Reacted by dlavati
11. bors

    added a commit that references this issue on Oct 30, 2018

    Auto merge of #55190 - dlavati:51574_rename_codemap_filemap, r=petroc…

    ...

    fb2446a
12. eddyb commented on Nov 3, 2018

    

    eddyb

    on Nov 3, 2018

    ContributorAuthor

    More actions

    I assume this is done after #55190?
13. eddyb

    closed this as completedon Nov 3, 2018
14. eddyb commented on Feb 10, 2020

    

    eddyb

    on Feb 10, 2020

    ContributorAuthor

    More actions

    I came across over this instance of cm today:
    

    rust/src/librustc_errors/lib.rs

    Line 149 in e6ec0d1

    pub fn splice_lines(&self, cm: &SourceMap) -> Vec<(String, Vec<SubstitutionPart>, bool)> {

    So we might need to do another pass just for easier to miss things like cm.
15. eddyb

    reopened this on Feb 10, 2020
16. jonas-schievink

    added

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

    on Feb 20, 2020
17. Dylan-DPC-zz

    added a commit that references this issue on Feb 23, 2020

    Rollup merge of rust-lang#69375 - Menschenkindlein:master, r=Dylan-DPC

    ...

    bdd275d
18. Alexendoo commented on Apr 30, 2020

    

    Alexendoo

    on Apr 30, 2020

    Member

    More actions

    Looks done after #69375

    👍React with 👍1Reacted by Eduard-Mihai Burtescu
19. Alexendoo

    closed this as completedon Apr 30, 2020