Skip to content

EvaluationCache overwrites its entries #50507

Open

Description

@Zoxc

When the insertion to EvaluationCache is changed to use HashMapExt::insert_same. It triggers an the assertion which checks that the old value is the same as the new one. This is because the DepNodeIndex changed.

Backtrace
Log output

cc @arielb1 @nikomatsakis

Activity

  1. added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Oct 2, 2018
  2. sasurau4 commented on Jan 28, 2021

    @sasurau4
    Contributor

    @nikomatsakis
    I looked into this issue.
    In #49834, the build seems failed at build stage0 core and left FIXME comment.
    When I changed the code same to #73792 and turn on parallel-compiler = true in config.toml, I met following tests failed but couldn't reproduce the build error same as #49834.

    failures:
        [ui] ui/associated-types/defaults-cyclic-fail-1.rs
        [ui] ui/associated-types/defaults-cyclic-fail-2.rs
        [ui] ui/privacy/privacy2.rs
        [ui] ui/privacy/privacy3.rs
        [ui] ui/type_length_limit.rs
    

    The cause of test fails are snapshot diffs mentioned at #75760, so this issue seems solved.
    Any other information or investigation needed? I'll work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions