Skip to content

make RegionVid use newtype_index! #45843

Closed

Description

@nikomatsakis

So @spastorino and @Nashenas88 have been on this awesome kick of making all "index-like things" use newtype_index!. In #45825, I made RegionVid implement Idx, but I didn't use newtype_index! because -- well, because dang it that PR is long enough. It'd be nice to do.

(I think btw we should shoot for not using public fields when we do these conversions -- I'd like to be able to transparently start using Nonzero to make Option<I>, as described in #45842.)

Activity

  1. added 2 commits that reference this issue on Nov 10, 2017
    cf7fe00
    f2fd277
  2. nikomatsakis commented on Nov 11, 2017

    @nikomatsakis
    ContributorAuthor
  3. added a commit that references this issue on Nov 26, 2017
    1be38e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions