You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tracking issue for Rc::downcast (rc_downcast feature) #44608
Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
Hehe, I can't quite find the right way to pick the right implementations.
All four combinations are "Trait", "Trait + Send", "Trait + Sync", "Trait + Send + Sync".
The frugal approach is just the first one for Rc and just the last one for Arc. The perfect would be to write just one that covered them all, for each of Rc and Arc. I think the pragmatic would be all four for both Rc and Arc.
Using the same tracking issue sounds fine: it’s a identical copy of a fairly small function. By the way, I think you can also remove an unsafe block by using the (relatively) new cast method of NonNull, instead of NonNull::new_unchecked.
Hmm it looks like only @alexcrichton can tell rfcbot to resolve the concern here, but I think we can consider the spirit of the process to be satisfied (if not the letter) and I would accept a stabilization PR. (Alex is away for a month.)
Activity
SimonSapin commentedon Mar 17, 2018
Looks good to me to stabilize.
@rfcbot fcp merge
rfcbot commentedon Mar 17, 2018
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:
Concerns:
arcresolved by Tracking issue for Rc::downcast (rc_downcastfeature) #44608 (comment)Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
alexcrichton commentedon Mar 19, 2018
@rfcbot concern arc
We should add to
Arcas well for consistency, right?SimonSapin commentedon Mar 19, 2018
On the implementation PR:
We can still do that.
alexcrichton commentedon Mar 19, 2018
Indeed!
bluss commentedon Mar 19, 2018
Hehe, I can't quite find the right way to pick the right implementations.
All four combinations are "Trait", "Trait + Send", "Trait + Sync", "Trait + Send + Sync".
The frugal approach is just the first one for Rc and just the last one for Arc. The perfect would be to write just one that covered them all, for each of Rc and Arc. I think the pragmatic would be all four for both Rc and Arc.
alexcrichton commentedon Mar 19, 2018
@bluss I'd be ok conservatively just doing
Arc<Any + Send + Sync>as I doubt most other combinations don't actually show up that often in practicejsgf commentedon May 17, 2018
Hi! I ran into this today. Any objections if I put together a PR for
Arc<Any + Send + Sync>?sfackler commentedon May 17, 2018
SGTM
jsgf commentedon May 17, 2018
Should I reuse this issue and
rc_downcast, or create new ones?SimonSapin commentedon May 17, 2018
Using the same tracking issue sounds fine: it’s a identical copy of a fairly small function. By the way, I think you can also remove an
unsafeblock by using the (relatively) newcastmethod ofNonNull, instead ofNonNull::new_unchecked.7 remaining items
Auto merge of #50836 - jsgf:arc-downcast, r=SimonSapin
SimonSapin commentedon Jun 6, 2018
@rfcbot resolve arc
The requested feature was implemented in #50836.
SimonSapin commentedon Jun 6, 2018
Hmm it looks like only @alexcrichton can tell rfcbot to resolve the concern here, but I think we can consider the spirit of the process to be satisfied (if not the letter) and I would accept a stabilization PR. (Alex is away for a month.)
alexcrichton commentedon Jun 27, 2018
@rfcbot resolved arc
rfcbot commentedon Jun 27, 2018
🔔 This is now entering its final comment period, as per the review above. 🔔
Stabilize rc_downcast
Rollup merge of rust-lang#52103 - tmccombs:rc_downcast, r=Mark-Simula…