You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tracking issue for RFC 1857: Stabilize drop order #43034
@aturon In the RFC I mentioned updating the book, but upon second thought relying on a particular drop order seems to be a niche use case. Therefore it seems reasonable to me to omit it in the book and only mention it in the reference. Do you agree with that?
@steveklabnik@carols10cents I am trying to find a good place in the book to put tell that drop order is specified. I guess if we were to do this it would go in the chapter about drop. Unfortunately, the example uses a struct with only one field, so we cannot use the example to talk about drop order. Maybe we could add an extra field and then explain which field is dropped first? Then, we could link to the reference for more information.
I am still not sure about mentioning drop order in the book, so I am also interested in your opinion regarding that.
Yes, we should mention it; we already do in the lifetimes section, I believe. The drop chapter is the right place though, and another example is a good idea.
Activity
aochagavia commentedon Jul 4, 2017
Besides documentation, I think a couple of tests would be useful as well to prevent accidentally changing the order.
aochagavia commentedon Jul 8, 2017
@aturon In the RFC I mentioned updating the book, but upon second thought relying on a particular drop order seems to be a niche use case. Therefore it seems reasonable to me to omit it in the book and only mention it in the reference. Do you agree with that?
vitalyd commentedon Jul 8, 2017
The book should mention that the drop order is specified, but can refer the reader to the reference for elaboration.
aochagavia commentedon Jul 9, 2017
@steveklabnik @carols10cents I am trying to find a good place in the book to put tell that drop order is specified. I guess if we were to do this it would go in the chapter about drop. Unfortunately, the example uses a struct with only one field, so we cannot use the example to talk about drop order. Maybe we could add an extra field and then explain which field is dropped first? Then, we could link to the reference for more information.
I am still not sure about mentioning drop order in the book, so I am also interested in your opinion regarding that.
steveklabnik commentedon Jul 10, 2017
Yes, we should mention it; we already do in the lifetimes section, I believe. The
dropchapter is the right place though, and another example is a good idea.arielb1 commentedon Jul 11, 2017
The "panic during initialization drops elements in reverse order" is actually a part of the "temporary lifetimes" rules, which are described in https://github.com/nikomatsakis/rust-memory-model/issues/17. Do we want to document them?
Rollup merge of rust-lang#43125 - aochagavia:stable_drop, r=arielb1
Centril commentedon Sep 15, 2018
I believe there's nothing left to do here, so closing.