Skip to content

Tracking issue for struct_field_attributes #41681

Closed
Closed
Tracking issue for struct_field_attributes#41681
Labels
B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-langRelevant to the language teamfinal-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.

Description

@mbrubeck
mbrubeck
opened on May 1, 2017

Status

Activity

  1. mbrubeck
    added
    B-unstableBlocker: Implemented in the nightly compiler and unstable.
    T-langRelevant to the language team
    on May 1, 2017

  2. SergioBenitez commented on May 19, 2017

    @SergioBenitez
    SergioBenitez
    on May 19, 2017
    Contributor

    This has been around for a while (since Jan. 2017, ~4 months) and appears to be quite solid in my testing. Is there a reason to not move this into FCP for stabilization? @brson

  3. brson
    added
    I-nominated
    on May 22, 2017

  4. brson commented on May 22, 2017

    @brson
    brson
    on May 22, 2017
    Contributor

    cc @rust-lang/lang Ready for stabilization?

  5. withoutboats commented on May 22, 2017

    @withoutboats
    withoutboats
    on May 22, 2017
    Contributor

    @rfcbot fcp merge

  6. withoutboats
    removed
    I-nominated
    on May 22, 2017

  7. rfcbot commented on May 23, 2017

    @rfcbot
    rfcbot
    on May 23, 2017

    Team member @withoutboats has proposed to merge this. The next step is review by the rest of the tagged teams:

    No concerns currently listed.

    Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  8. rfcbot commented on Jun 3, 2017

    @rfcbot
    rfcbot
    on Jun 3, 2017

    🔔 This is now entering its final comment period, as per the review above. 🔔

  9. rfcbot
    added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Jun 3, 2017

  10. rfcbot commented on Jun 13, 2017

    @rfcbot
    rfcbot
    on Jun 13, 2017

    The final comment period is now complete.

  11. nikomatsakis commented on Jun 13, 2017

    @nikomatsakis
    nikomatsakis
    on Jun 13, 2017
    Contributor

    Now that we've decided to stabilize this, we need someone to prepare a stabilization PR! There are some general instructions for how to do this on forge. Based on a quick run of rg struct_field_attributes, this should be a pretty straight-forward case! Just have to remove some of the feature-gate tests from libsyntax and a few other places.

    The other major thing we need before we can stabilize is documentation PRs.

  12. nikomatsakis
    added
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Jun 13, 2017

  13. nikomatsakis commented on Jun 13, 2017

    @nikomatsakis
    nikomatsakis
    on Jun 13, 2017
    Contributor

    Marking as E-mentor. The instructions are here.

  14. tirr-c commented on Jun 13, 2017

    @tirr-c
    tirr-c
    on Jun 13, 2017
    Contributor

    I want to work on removing the feature gate.

  15. nikomatsakis commented on Jun 14, 2017

    @nikomatsakis
    nikomatsakis
    on Jun 14, 2017
    Contributor

    @VBChunguk nice job :)

  16. frewsxcv
    added a commit that references this issue on Jun 16, 2017

    Rollup merge of rust-lang#42656 - VBChunguk:struct-field-attributes, …

    999f3ad

  17. nikomatsakis commented on Jul 17, 2017

    @nikomatsakis
    nikomatsakis
    on Jul 17, 2017
    Contributor

    Did we actually write stable documentation here? Skimming the threads I didn't see any PRs...?

  18. Mark-Simulacrum
    added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Jul 22, 2017

  19. theduke commented on Aug 31, 2017

    @theduke
    theduke
    on Aug 31, 2017
    Contributor

    This was stabilized with 1.20 as far as I can tell?

  20. hcpl
    added a commit that references this issue on Sep 5, 2017

    Add commented tests regarding `extprim`

    8ccf1a5
  21. Manishearth
    added
    hacktoberfest
    and removed
    hacktoberfest
    on Sep 28, 2017

  22. cramertj commented on Jan 17, 2018

    @cramertj
    cramertj
    on Jan 17, 2018
    Member

    Stabilized-- closing. LMK if there are any outstanding items here and I'll reopen.

  23. cramertj
    closed this as completedon Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-langRelevant to the language teamfinal-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions