Tracking issue for {Vec,String}::splice #32310

Activity

1. alexcrichton

   added

   B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   on Mar 17, 2016
2. aturon

   added

   E-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.

   on Feb 6, 2017
3. aturon commented on Feb 6, 2017

   

   aturon

   on Feb 6, 2017

   Contributor

   More actions

   There's a preliminary implementation here, which could easily be picked up and brought over the finish line!
4. brson

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   on Mar 1, 2017
5. alexcrichton

   added

   B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.

   and removed

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   E-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.

   B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.

   on Apr 24, 2017
6. frewsxcv

   added a commit that references this issue on Apr 24, 2017

   Rollup merge of rust-lang#40434 - mattico:splice-update, r=alexcrichton

   ...

   1ae52ab
7. frewsxcv

   added 3 commits that reference this issue on Apr 24, 2017

   Rollup merge of rust-lang#40434 - mattico:splice-update, r=alexcrichton

   ...

   0547f71

   Rollup merge of rust-lang#40434 - mattico:splice-update, r=alexcrichton

   ...

   3cd7fed

   Rollup merge of rust-lang#40434 - mattico:splice-update, r=alexcrichton

   ...

   5947cec
8. bors

   added a commit that references this issue on Apr 25, 2017

   Auto merge of #40434 - mattico:splice-update, r=alexcrichton

   ...

   c7e724a
9. 12 remaining items

   Load more

10. rfcbot commented on Aug 23, 2017

    

    rfcbot

    on Aug 23, 2017

    More actions

    🔔 This is now entering its final comment period, as per the review above. 🔔
11. rfcbot

    added

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    and removed

    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

    on Aug 23, 2017
12. kennytm commented on Aug 23, 2017

    

    kennytm

    on Aug 23, 2017

    Member

    More actions

    IMO if String::splice is not returning the previous data, the method shouldn't be really called splice.
13. alexcrichton

    added a commit that references this issue on Aug 30, 2017

    Rollup merge of rust-lang#44044 - mattico:string-splice-return, r=dto…

    ...

    581dc93
14. rfcbot commented on Sep 2, 2017

    

    rfcbot

    on Sep 2, 2017

    More actions

    The final comment period is now complete.
15. dtolnay commented on Sep 17, 2017

    

    dtolnay

    on Sep 17, 2017

    Member

    More actions

    The FCP above applies to Vec::splice. I filed #44643 as the tracking issue for String::splice which remains unstable with its new signature.

    ❤️React with ❤️1Reacted by kennytm
16. budziq

    added a commit that references this issue on Sep 17, 2017

    stabilized vec_splice (fixes rust-lang#32310)

    This issue will close once commit 7b932d2 is merged into the 'master' branch.

    7b932d2
17. alexcrichton

    added 2 commits that reference this issue on Sep 18, 2017

    Rollup merge of rust-lang#44640 - budziq:stabilize_splice, r=dtolnay

    ...

    This issue will close once commit 054a46e is merged into the 'incoming' branch.

    054a46e

    Rollup merge of rust-lang#44640 - budziq:stabilize_splice, r=dtolnay

    ...

    This issue will close once commit fa9dd27 is merged into the 'incoming' branch.

    fa9dd27
18. bors

    closed this as completedin #44640on Sep 18, 2017
19. dtolnay

    added a commit that references this issue on Sep 25, 2017

    stabilized vec_splice (fixes rust-lang#32310)

    This issue will close once commit bce9b14 is merged into the 'main' branch.

    bce9b14