Add fn skip(n: uint) with a default implementation to Reader

Reader should have an extra fn that allows skipping a number of bytes. The default implementation could look something like:

fn skip(n: uint) { let _ = self.read(Vec::from_elem(n, 0u8); }

However, BufReader could implement the fn by simply updating the internal cursor. This would allow more efficient skipping w/o having to require Seek.

@alexcrichton

This seems useful though reader does have a few methods on it already. I'm wondering what @alexcrichton thinks?
Edit: I'm not sure if this is a worthwhile change anymore. We can easily to reader.read_exact(n) to achieve the same thing.

I'm worried about adding more methods to readers that downstream consumers need to consider to override. Having one flush() method is unfortunate, and I think time should be taken to consider whether this is justified to add it or not.

I don't think that we can quite use read_exact for this because in theory skip doesn't actually have to read any data. It does sound quite similar to seek though...

Any news on this? I'm writing an IFF reader and I want users to be able to skip chunk bodies, requiring Seek for just this seems overkill.

The problem is that given today's (and likely future) coherence rules, you cannot create a trait that uses Seek if available but otherwise falls back to a less efficient Reader:

impl<T: Seek> PossiblyInefficientSeek for T {
    // ...
}

impl<T: Reader> PossiblyInefficientSeek for T {
    // ...
}

This is actually a decent motivating use-case for allowing an implementation of a trait to refine an existing implementation defined on a superset of types.

@pongad

@pongad I do not think read_exact is appropriate, since it requires allocating a buffer of n size even if the backend supports efficient skipping.

@alexcrichton

@alexcrichton it is true that having too many random convenience methods can be a problem, but I think that it makes sense to add methods for operations that can be implemented much more efficiently in some contexts than others. In other words, while skip is technically implementable as a read, there is a big efficiency difference between a call to fseek and reading tons of bytes.

Add a new method skip(n: uint) to std::io::Reader.

Add skip(n: uint) to Seek, File and BufferedReader.

@carllerche

@carllerche did this end up getting addressed in io reform?

@steveklabnik

@steveklabnik Not yet. I think (hope) it is coming pre 1.0 though. cc @aturon

Nominating for 1.0-beta P-high. (Should be trivial.)

P-high, I-needs-decision (not 1.0 beta blocker)

In today's day and age this sort of addition (to a core trait like Read) will require an RFC, so I'm going to close this in favor of that course of action.

#53294

Auto merge of rust-lang#13989 - Veykril:hover, r=Veykril

change `literal_string_with_formatting_args` lint category to nursery (…

Navigation Menu

Repository navigation

Add fn skip(n: uint) with a default implementation to Reader #13989

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Add fn skip(n: uint) with a default implementation to Reader #13989

Description

Activity

pongad commented on May 14, 2014

alexcrichton commented on May 14, 2014

nox commented on Jul 11, 2014

wycats commented on Jul 20, 2014

wycats commented on Jul 20, 2014

nikomatsakis commented on Aug 6, 2014

steveklabnik commented on Feb 14, 2015

carllerche commented on Feb 14, 2015

aturon commented on Feb 16, 2015

pnkfelix commented on Feb 19, 2015

alexcrichton commented on Jan 21, 2016

youknowone commented on Apr 21, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions