Skip to content

Add a regression test for #132587 #132727

Closed
#159529
Closed
Add a regression test for #132587#132727
#159529
Labels
A-parserArea: The lexing & parsing of Rust source code to an ASTA-proc-macrosArea: Procedural macrosC-bugCategory: This is a bug.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@jieyouxu
jieyouxu
opened on Nov 7, 2024

#132587 partially reverted #129346 because that caused a test failure in cfg_eval, but the revert PR didn't come with a test because it involved proc-macros and was hard to minimize. We should still add a regression test.

@rustbot label +E-needs-test

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    on Nov 7, 2024

  2. jieyouxu commented on Nov 7, 2024

    @jieyouxu
    jieyouxu
    on Nov 7, 2024
    MemberAuthor

    Initial report at #129346 (review)

  3. jieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-parserArea: The lexing & parsing of Rust source code to an AST
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Nov 7, 2024

  4. jieyouxu commented on Nov 7, 2024

    @jieyouxu
    jieyouxu
    on Nov 7, 2024
    MemberAuthor

    See also exploration in #132587, e.g. #132587 (comment)

  5. jieyouxu
    added
    A-proc-macrosArea: Procedural macros
    on Nov 16, 2024

  6. jieyouxu commented on Nov 17, 2024

    @jieyouxu
    jieyouxu
    on Nov 17, 2024
    MemberAuthor

    I briefly looked at this and the minimization is tricky.

    @rustbot label +E-medium

  7. rustbot
    added
    E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
    on Nov 17, 2024

  8. yegeunyang commented on Jan 28, 2025

    @yegeunyang
    yegeunyang
    on Jan 28, 2025 · Hidden as resolved
  9. rustbot
    assigned
    yegeunyang
    on Jan 28, 2025

  10. yegeunyang commented on Jan 30, 2025

    @yegeunyang
    yegeunyang
    on Jan 30, 2025 · Hidden as resolved
  11. rustbot
    unassigned
    yegeunyang
    on Jan 30, 2025
  12. JonathanBrouwer
    added 2 commits that reference this issue on Jul 20, 2026

    Rollup merge of rust-lang#159529 - UditDewan:nested-replacement-range…

    816813e

    Rollup merge of rust-lang#159529 - UditDewan:nested-replacement-range…

    ecee943
  13. rust-bors
    closed this as completedin #159529on Jul 20, 2026
  14. rust-timer
    added a commit that references this issue on Jul 20, 2026

    Unrolled build for #159529

    943c5bb
  15. lnicola
    added a commit that references this issue on Aug 17, 2026

    Rollup merge of #159529 - UditDewan:nested-replacement-ranges-test, r…

    f22575a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-parserArea: The lexing & parsing of Rust source code to an ASTA-proc-macrosArea: Procedural macrosC-bugCategory: This is a bug.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions