path attribute is silently accepted and ignored for inline mod items.

Consider the following program p.rs:

#[path="q.rs"] mod q {
    pub fn q_main() { println!("Hello World"); }
}

fn main() { q::q_main() }

I don't know if this is considered a bug or a feature, but we should probably emit a warning when we encounter that useless path attribute attached to q above.

Doesn't seem useless to me. The reference gives this seemingly reasonable example:

The directories and files used for loading external file modules can be influenced with the path attribute.
#[path = "thread_files"]
mod thread {
    // Load the `local_data` module from `thread_files/tls.rs`
    #[path = "tls.rs"]
    mod local_data;
}

Now suppose you're in a build script and want to include src/tls.rs. Is there a better way than

// This module hides some optional stuff
#[cfg(foo_bar)]
#[path = ""]
mod thread {
    #[path = "src/tls.rs"]
    mod local_data;
}

Yeah, to my knowledge this is expected and intentional behavior; closing.

Auto merge of rust-lang#13156 - Veykril:macro-stmts, r=Veykril

Auto merge of rust-lang#13156 - y21:for_each_expr_visitor_refactor, r…

Navigation Menu

Repository navigation

path attribute is silently accepted and ignored for inline mod items. #13156

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

path attribute is silently accepted and ignored for inline mod items. #13156

Description

Activity

gkoz commented on Feb 2, 2016

Mark-Simulacrum commented on May 30, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions