Repository navigation
x fmt formats way too many files #131324
Description
I am in this state (only 1 modified file):
╰ ➤ git diff --stat
compiler/rustc_codegen_ssa/src/mir/mod.rs | 31 ++++++++++++++++++++++++++++++-
1 file changed, 30 insertions(+), 1 deletion(-)
But I just tried to format and got this:
╰ ➤ x fmt
Building bootstrap
Finished `dev` profile [unoptimized] target(s) in 0.03s
fmt: formatted 5608 modified files
Build completed successfully in 0:00:01
Something is quite wrong here. Formatting of only changed files must be correct, otherwise some files in the tree will get spurious formatting changes in PRs.
Perhaps #131296 is related? I have a vague memory of seeing this misbehavior occasionally in the past though I'm only now remembering to file an issue.
Activity
bjorn3 commentedon Oct 6, 2024
Don't we check formatting of all files in CI anyway?
onur-ozkan commentedon Oct 6, 2024
Most likely.
On CI, yes.
saethlin commentedon Oct 6, 2024
Interesting. I swear I've seen spurious formatting changes in PRs. Might be some other effect.
Rollup merge of rust-lang#131331 - onur-ozkan:131296, r=Kobzol
Unrolled build for rust-lang#131331
clubby789 commentedon Oct 7, 2024
Should be closed by #131331 (GH didn't pick up the comment)