Skip to content

Stop using "Hack to avoid function merging" #129438

Closed
#129468
Closed
Stop using "Hack to avoid function merging"#129438
#129468
Assignees
rustbot
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@scottmcm
scottmcm
opened on Aug 23, 2024

There's a whole bunch of this:

tests\assembly\asm\x86-types.rs
125:            // Hack to avoid function merging
142:            // Hack to avoid function merging

tests\assembly\asm\x86-modifiers.rs
41:            // Hack to avoid function merging

tests\assembly\asm\s390x-types.rs
45:// Hack to avoid function merging

tests\assembly\asm\riscv-types.rs
93:            // Hack to avoid function merging
110:            // Hack to avoid function merging

tests\assembly\asm\powerpc-types.rs
46:// Hack to avoid function merging

tests\assembly\asm\mips-types.rs
46:// Hack to avoid function merging

tests\assembly\asm\loongarch-type.rs
42:// Hack to avoid function merging

tests\assembly\asm\hexagon-types.rs
44:            // Hack to avoid function merging
61:            // Hack to avoid function merging
80:    // Hack to avoid function merging
95:    // Hack to avoid function merging

tests\assembly\asm\arm-types.rs
120:            // Hack to avoid function merging
137:            // Hack to avoid function merging

tests\assembly\asm\arm-modifiers.rs
46:            // Hack to avoid function merging

tests\assembly\asm\aarch64-types.rs
119:            // Hack to avoid function merging
140:            // Hack to avoid function merging

tests\assembly\asm\aarch64-modifiers.rs
32:            // Hack to avoid function merging

Do we really need to hack it, though? We have a flag for that:

//@ compile-flags: -Zmerge-functions=disabled

This issue has been assigned to @Rajveer100 via this comment.

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Aug 23, 2024
  2. jieyouxu
    added
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Aug 23, 2024
  3. scottmcm
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Aug 23, 2024
  4. Rajveer100
    added 2 commits that reference this issue on Aug 23, 2024

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    ca502db

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    7453128

  5. saksham-agarwal-dev commented on Aug 30, 2024

    @saksham-agarwal-dev
    saksham-agarwal-dev
    on Aug 30, 2024

    @rustbot claim

  6. rustbot
    assigned
    saksham-agarwal-dev
    on Aug 30, 2024

  7. jieyouxu commented on Aug 30, 2024

    @jieyouxu
    jieyouxu
    on Aug 30, 2024
    Member

    @saksham-agarwal-dev Hi, thanks for your interest. However, I believe @Rajveer100 already has an open PR (#129468) trying to address this.

    @rustbot assign @Rajveer100

  8. rustbot
    assigned
    rustbot
    and unassigned
    saksham-agarwal-dev
    on Aug 30, 2024
  9. Rajveer100
    added 5 commits that reference this issue on Aug 30, 2024

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    8575a93

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    25b4cbd

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    dd2a955

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    800a1ce

    [testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid …

    b324fcb
  10. compiler-errors
    added a commit that references this issue on Sep 7, 2024

    Rollup merge of rust-lang#129468 - Rajveer100:hack-to-avoid-function-…

    adcee23
  11. bors
    closed this as completedin b324fcbon Sep 7, 2024
  12. rust-timer
    added a commit that references this issue on Sep 7, 2024

    Unrolled build for rust-lang#129468

    b247985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions