run-make: audit tests that codegen for specific targets #129390

Activity

1. rustbot

   added

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Aug 22, 2024
2. jieyouxu

   self-assigned this

   on Aug 22, 2024
3. jieyouxu

   added

   A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rs

   A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustc

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   C-bugCategory: This is a bug.Category: This is a bug.

   and removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Aug 22, 2024
4. jieyouxu commented on Aug 22, 2024

   

   jieyouxu

   on Aug 22, 2024

   Last edited by jieyouxu

   MemberAuthor

   More actions

   E.g. for print-target-list this looks a bit awkward, maybe we can dump //@ needs-llvm-components: $KNOWN_LLVM_COMPONENTS, where $KNOWN_LLVM_COMPONENTS is shamelessly stolen from tidy:

   rust/src/tools/tidy/src/target_specific_tests.rs

   Lines 13 to 31 in 0f6e1ae

   	const KNOWN_LLVM_COMPONENTS: &[&str] = &[
   	"aarch64",
   	"arm",
   	"avr",
   	"bpf",
   	"csky",
   	"hexagon",
   	"loongarch",
   	"m68k",
   	"mips",
   	"msp430",
   	"nvptx",
   	"powerpc",
   	"riscv",
   	"sparc",
   	"systemz",
   	"webassembly",
   	"x86",
   	];

   Between this directive and COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS, it is not exactly very clear what's happening.
5. matthiaskrgr

   added 2 commits that reference this issue on Aug 31, 2024

   Rollup merge of rust-lang#129605 - jieyouxu:needs-llvm-components, r=…

   ...

   This issue will close once commit 004014a is merged into the 'master' branch.

   004014a

   Rollup merge of rust-lang#129605 - jieyouxu:needs-llvm-components, r=…

   ...

   This issue will close once commit d354d4d is merged into the 'master' branch.

   d354d4d
6. bors

   closed this as completedin d354d4don Aug 31, 2024
7. rust-timer

   added a commit that references this issue on Aug 31, 2024

   Unrolled build for rust-lang#129605

   ...

   This issue will close once commit bfb6bb7 is merged into the 'master' branch.

   bfb6bb7