Skip to content

safe keyword is not feature-gated #126755

Closed
Closed

Description

@compiler-errors

In #126749, @ehuss reports:

Another issue appears that safe is not feature-gated. The following seems to build without a feature gate:

safe fn foo() {}

Originally posted by @ehuss in #126749 (comment)

Tracking:

Activity

  1. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 20, 2024
  2. added and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 20, 2024
  3. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Jun 20, 2024
  4. compiler-errors commented on Jun 20, 2024

    @compiler-errors
    ContributorAuthor

    this regressed in #124482

  5. traviscross commented on Jun 20, 2024

    @traviscross
    Contributor
  6. added a commit that references this issue on Jun 20, 2024
  7. added a commit that references this issue on Jun 21, 2024
  8. added a commit that references this issue on Jun 21, 2024
  9. apiraino commented on Jun 21, 2024

    @apiraino
    Contributor

    WG-prioritization assigning priority (Zulip discussion).

    @rustbot label -I-prioritize +P-high

  10. added
    P-highHigh priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Jun 21, 2024
  11. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jun 21, 2024
  12. compiler-errors commented on Jul 5, 2024

    @compiler-errors
    ContributorAuthor

    This got fixed and beta backported

  13. added a commit that references this issue on Aug 3, 2024
  14. added a commit that references this issue on Aug 3, 2024
  15. added a commit that references this issue on Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P-highHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions