Skip to content

Adding _int.to_str triples time to compile standard library #124

Closed

Description

@jyasskin

Before jyasskin/rust@684502b:
$ time ./rustboot -L . -shared -o libstd.dylib lib/std.rc
real 0m1.205s; 0m1.168s; 0m1.159s

After:
$ time ./rustboot -L . -shared -o libstd.dylib lib/std.rc
real 0m3.375s; 0m3.571s; 0m3.421s

This is with CFG_NATIVE=1. There must be something pathological in the compiler. A 40-line function shouldn't be able to triple the build time.

Activity

  1. graydon commented on Jul 25, 2010

    @graydon
    Contributor

    Yeah. I think I added a bit too much un-guarded logging in the past week. I'll do a profile-and-shave run on monday and should get it back down a ways.

  2. graydon commented on Jul 26, 2010

    @graydon
    Contributor

    Good news: found the source of pain. Bad news: will take a little bit of time to fix. On it this afternoon.

  3. graydon commented on Jul 26, 2010

    @graydon
    Contributor

    I think this is fixed enough to be tolerable for now. There is still a bit of a sore spot in the RA but it's nothing spectacularly non-local or non-linear like you were seeing. Let me know if you are feeling it slowing down again.

  4. graydon commented on Jul 27, 2010

    @graydon
    Contributor

    Er, for reference sake the commit that did most of the fixing was 3d69407.

  5. added a commit that references this issue on Jul 19, 2017
    1a697f9
  6. added a commit that references this issue on Nov 29, 2018
  7. added a commit that references this issue on Jan 19, 2019
    e39ea75
  8. added a commit that references this issue on Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions