Skip to content

regression: visibility qualifiers are not permitted #121607

Closed
Closed
regression: visibility qualifiers are not permitted#121607
Assignees
fmease
Labels
A-visibilityArea: Visibility / privacyP-highHigh priorityS-has-mcveStatus: A Minimal Complete and Verifiable Example has been found for this issueT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
Milestone
1.77.0

Description

@Mark-Simulacrum
Mark-Simulacrum
opened on Feb 25, 2024
[INFO] [stdout] error[E0449]: visibility qualifiers are not permitted here
[INFO] [stdout]    --> src/par_stream.rs:647:16
[INFO] [stdout]     |
[INFO] [stdout] 647 |                   pool.spawn(FnOnce!(move |pool: &P::ThreadPool| {
[INFO] [stdout]     |  ____________________________^
[INFO] [stdout] 648 | |                     let mut process_tasks = tasks.into_iter();
[INFO] [stdout] 649 | |
[INFO] [stdout] 650 | |                     let mut tasks = (0..pool.threads()).map(|_| Vec::new()).collect::<Vec<_>>();
[INFO] [stdout] ...   |
[INFO] [stdout] 719 | |                     }
[INFO] [stdout] 720 | |                 }))
[INFO] [stdout]     | |__________________^
[INFO] [stdout]     |
[INFO] [stdout]     = note: trait items always share the visibility of their trait
[INFO] [stdout]     = note: this error originates in the macro `FnOnce` (in Nightly builds, run with -Z macro-backtrace for more info)

Activity

  1. Mark-Simulacrum
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
    on Feb 25, 2024
  2. Mark-Simulacrum
    added this to the 1.77.0 milestone on Feb 25, 2024
  3. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 25, 2024

  4. lukas-code commented on Feb 25, 2024

    @lukas-code
    lukas-code
    on Feb 25, 2024
    Contributor

    minimized: (playground)

    trait Foo {
    fn foo() {
        pub struct Bar;
        impl Bar {
            pub fn bar() {}
        }
    }
}

    bisects to #119505 cc @fmease

    @rustbot label -E-needs-bisection -E-needs-mcve S-has-mcve A-visibility

  5. rustbot
    added
    A-visibilityArea: Visibility / privacy
    S-has-mcveStatus: A Minimal Complete and Verifiable Example has been found for this issue
    and removed
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
    on Feb 25, 2024
  6. fmease
    removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 26, 2024
  7. fmease
    self-assigned this
    on Feb 26, 2024

  8. fmease commented on Feb 26, 2024

    @fmease
    fmease
    on Feb 26, 2024
    Member

    I already have a PR fixing this, namely #120698. I'd like to improve the approach though, that's why it's waiting on author atm.

    I've been aware of this regression (cc #119924) but I should definitely prioritize the PR then.

  9. apiraino commented on Feb 26, 2024

    @apiraino
    apiraino
    on Feb 26, 2024
    Contributor

    WG-prioritization assigning priority (Zulip discussion)

    Thanks @fmease and @compiler-errors for jumping on this!

    @rustbot label -I-prioritize +P-critical

  10. rustbot
    added
    P-criticalCritical priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Feb 26, 2024

  11. fmease commented on Feb 29, 2024

    @fmease
    fmease
    on Feb 29, 2024
    Member

    Downgrading the priority as discussed here.

  12. fmease
    added
    P-highHigh priority
    and removed
    P-criticalCritical priority
    on Feb 29, 2024
  13. GuillaumeGomez
    added a commit that references this issue on Mar 7, 2024

    Rollup merge of rust-lang#122004 - fmease:astvalidator-min-fix, r=com…

    2e3bde2
  14. rust-timer
    added a commit that references this issue on Mar 8, 2024

    Unrolled build for rust-lang#122004

    97034b1

  15. fmease commented on Mar 15, 2024

    @fmease
    fmease
    on Mar 15, 2024
    Member

    Fixed by #122004.
    Backported in #122524.
    Closing as completed.

  16. fmease
    closed this as completedon Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-visibilityArea: Visibility / privacyP-highHigh priorityS-has-mcveStatus: A Minimal Complete and Verifiable Example has been found for this issueT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions