rustdoc: search should prioritize matching capitalization #119480

Activity

1. joshtriplett

   added

   T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.

   A-rustdoc-searchArea: Rustdoc's search featureArea: Rustdoc's search feature

   on Dec 31, 2023
2. rustbot

   added

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Dec 31, 2023
3. fmease

   added

   C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.

   and removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Jan 1, 2024
4. camelid commented on Jan 8, 2024

   

   camelid

   on Jan 8, 2024

   Last edited by camelid

   Member

   More actions

   It might also make sense to make this based on whether there were capital letters in the user's input. Vim has a similar feature that can be enabled, where searching with all lowercase is case-insensitive, but mixed-case is sensitive. In rustdoc's case, we could do something similar, except make it case-preferenced rather than exclude non-matching capitalization altogether.
5. tgross35 commented on Feb 28, 2024

   

   tgross35

   on Feb 28, 2024

   Last edited by tgross35

   Member

   More actions

   The Vim style is smartcase (ripgrep has a --smart-case flag), which matches case insensitive unless there are any uppercase characters, in which case it does a case-sensitive match.

   However, that is better for when you have binary results (either it matches or it doesn't), giving precedence to exact-case matches is better when you can rank the results. This is what e.g. https://github.com/kentcdodds/match-sorter does.

   (I would have liked this for adding a PATH alias in #119748)
6. lolbinarycat commented on Aug 22, 2024

   

   lolbinarycat

   on Aug 22, 2024

   Contributor

   More actions

   @rustbot claim
7. rustbot

   assigned

   lolbinarycat

   on Aug 22, 2024
8. lolbinarycat

   added 5 commits that reference this issue on Aug 22, 2024

   rustdoc: show exact case-sensitive matches first

   ...

   This issue will close once commit 7478e00 is merged into the 'master' branch.

   7478e00

   rustdoc: show exact case-sensitive matches first

   ...

   This issue will close once commit 74a2164 is merged into the 'master' branch.

   74a2164

   rustdoc: show exact case-sensitive matches first

   ...

   This issue will close once commit 4d66492 is merged into the 'master' branch.

   4d66492

   rustdoc: show exact case-sensitive matches first

   ...

   This issue will close once commit f21a96f is merged into the 'master' branch.

   f21a96f

   rustdoc: show exact case-sensitive matches first

   ...

   This issue will close once commit 4c5e888 is merged into the 'master' branch.

   4c5e888
9. workingjubilee

   added 3 commits that reference this issue on Aug 24, 2024

   Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…

   ...

   This issue will close once commit 17d312c is merged into the 'master' branch.

   17d312c

   Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…

   ...

   This issue will close once commit 616626a is merged into the 'master' branch.

   616626a

   Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…

   ...

   This issue will close once commit 25a3c88 is merged into the 'master' branch.

   25a3c88
10. matthiaskrgr

    added 2 commits that reference this issue on Aug 24, 2024

    Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…

    ...

    This issue will close once commit 11355f5 is merged into the 'master' branch.

    11355f5

    Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…

    ...

    This issue will close once commit 8919cbe is merged into the 'master' branch.

    8919cbe
11. tgross35

    added a commit that references this issue on Aug 25, 2024

    Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…

    ...

    This issue will close once commit 093249a is merged into the 'main' branch.

    093249a
12. bors

    closed this as completedin 4c5e888on Aug 25, 2024
13. rust-timer

    added a commit that references this issue on Aug 25, 2024

    Unrolled build for rust-lang#129430

    ...

    This issue will close once commit d0745dd is merged into the 'master' branch.

    d0745dd
14. lolbinarycat commented on Sep 3, 2024

    

    lolbinarycat

    on Sep 3, 2024

    Contributor

    More actions

    reopening this because it's only fixed in the simplest case, if you use a full path it will not be fixed.
15. lolbinarycat

    reopened this on Sep 3, 2024