Skip to content

go through uses of DefineOpaqueTypes::No and either document or change them #116652

Closed
1 of 1 issue completed
Closed
go through uses of DefineOpaqueTypes::No and either document or change them#116652
1 of 1 issue completed
Assignees
oli-obk
Labels
A-impl-traitArea: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@oli-obk
oli-obk
opened on Oct 12, 2023

This issue can be resolved in individual steps (each application of all steps should be their own commit!):

  1. flip a single usage of DefineOpauqeTypes::No to Yes
  2. see what tests fail, document the site by mentioning the test in a comment, revert to ::No, and open a PR.
  3. If no tests fail, still open a PR and assign to @oli-obk or @compiler-errors and leave a comment that there's no test exercising it. We'll try to come up with a test and/or run crater to find examples.

Activity

  1. oli-obk
    added this to type alias impl trait stabilizationon Oct 12, 2023
  2. oli-obk
    converted this from a draft issue on Oct 12, 2023
  3. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Oct 12, 2023
  4. oli-obk
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    A-impl-traitArea: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Oct 12, 2023

  5. goldpanth3r commented on Oct 12, 2023

    @goldpanth3r
    goldpanth3r
    on Oct 12, 2023

    Hey @oli-obk! I would like to try to contribute to this. Could you explain Step 1:flip a site to Yes? I tried to search for site and DefineOpaqueTypes::No in the codebase, but couldn't learn much.

  6. matthiaskrgr commented on Oct 12, 2023

    @matthiaskrgr
    matthiaskrgr
    on Oct 12, 2023
    Member

    I think it means to just search for DefineOpaqueTypes::No for example:

    compiler/rustc_trait_selection/src/traits/fulfill.rs:540:                                    .eq(DefineOpaqueTypes::No, a.args, b.args)

    and change it to DefineOpaqueTypes::Yes 🙃

  7. chansuke commented on Oct 23, 2023

    @chansuke
    chansuke
    on Oct 23, 2023
    Contributor

    @rustbot claim

  8. rustbot
    assigned
    chansuke
    on Oct 23, 2023
  9. oli-obk
    assigned
    oli-obk
    and unassigned
    chansuke
    on Feb 21, 2024
  10. oli-obk
    removed
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Feb 21, 2024
  11. bors
    added 2 commits that reference this issue on Apr 15, 2024

    Auto merge of rust-lang#123962 - oli-obk:define_opaque_types5, r=<try>

    fe30d25

    Auto merge of rust-lang#123962 - oli-obk:define_opaque_types5, r=<try>

    035f40f

  12. 18 remaining items

  13. matthiaskrgr
    added 2 commits that reference this issue on Jun 14, 2024

    Rollup merge of rust-lang#123962 - oli-obk:define_opaque_types5, r=lcnr

    160b200

    Rollup merge of rust-lang#123962 - oli-obk:define_opaque_types5, r=lcnr

    0468462
  14. rust-timer
    added a commit that references this issue on Jun 14, 2024

    Unrolled build for rust-lang#123962

    f3aabc3
  15. GuillaumeGomez
    added a commit that references this issue on Jun 19, 2024

    Rollup merge of rust-lang#126675 - oli-obk:diagnostics_opaque, r=jack…

    93fd3d6
  16. fee1-dead
    added a commit that references this issue on Jun 19, 2024

    Rollup merge of rust-lang#126675 - oli-obk:diagnostics_opaque, r=jack…

    e649eca
  17. rust-timer
    added a commit that references this issue on Jun 19, 2024

    Unrolled build for rust-lang#126675

    dad963b
  18. matthiaskrgr
    added 2 commits that reference this issue on Jun 24, 2024

    Rollup merge of rust-lang#126673 - oli-obk:dont_rely_on_err_reporting…

    a12f2d2

    Rollup merge of rust-lang#126673 - oli-obk:dont_rely_on_err_reporting…

    b452fc4
  19. compiler-errors
    added a commit that references this issue on Jun 24, 2024

    Rollup merge of rust-lang#126673 - oli-obk:dont_rely_on_err_reporting…

    49bdf46
  20. rust-timer
    added a commit that references this issue on Jun 24, 2024

    Unrolled build for rust-lang#126673

    27a6967
  21. bors
    added a commit that references this issue on Jun 25, 2024

    Auto merge of rust-lang#125610 - oli-obk:define_opaque_types14, r=com…

    164e129
  22. flip1995
    added a commit that references this issue on Jun 28, 2024

    Rollup merge of #124080 - oli-obk:define_opaque_types10, r=compiler-e…

    902f248
  23. lolbinarycat
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 22, 2025

  24. oli-obk commented on Oct 6, 2026

    @oli-obk
    oli-obk
    on Oct 6, 2026
    ContributorAuthor

    These will all be handled by landing the next solver

  25. oli-obk
    closed this as completedon Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-impl-traitArea: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions