Repository navigation
rustbuild: some x.py targets no longer print their dependencies being built #110506
Description
When running x.py install for example, x.py would previously show the build (cargo) output when building cargo during x.py install, but that is no longer the case. Is that intentional?
....
Uplifting rustc (stage1 -> stage3)
Building tool cargo (stage2 -> stage3)
Building tool cargo-credential-1password (stage2 -> stage3)
Dist cargo-1.71.0-dev-x86_64-unknown-linux-gnu
finished in 2.176 seconds
Install cargo stage2 (Some(x86_64-unknown-linux-gnu))
Activity
albertlarsan68 commentedon Apr 18, 2023
It's not intentional AFAIK, but I don't see a recent PR that could have broken this off the top of my head.
Do you have a commit/timeframe where this worked correctly?
matthiaskrgr commentedon Apr 18, 2023
Hmm I would guess it still worked last weekend?
jyn514 commentedon Apr 18, 2023
Are you sure cargo is actually being built?
stage2 -> stage3makes me think it's using cached stage 2 artifacts.matthiaskrgr commentedon Apr 18, 2023
Might be 103ed0e
matthiaskrgr commentedon Apr 18, 2023
Yes, I can see rustc building cargo and its deps in htop while x.py does not print any updates 😅
jyn514 commentedon Apr 18, 2023
oh lol that would do it
cc @weihanglo
weihanglo commentedon Apr 18, 2023
Sounds like we do need
stream_cargothere? I'll put it back then!albertlarsan68 commentedon Apr 18, 2023
Is there not a
try_runway of doing things?jyn514 commentedon Apr 18, 2023
Yes, there's a try_run, that would be best.
Rollup merge of rust-lang#110507 - weihanglo:print-try-run-output, r=…