Skip to content

add bootstrap tests for detecting src and out #109120

Open

Description

@jyn514

I was thinking about the following cases when I wrote the comment in #109055

  1. Running bootstrap from the source root.
  2. Running from a subdirectory of the source root.
  3. Running from outside the source root.
  4. Running on a different machine from where bootstrap was compiled (which will be important for no python in shell scripts #107812). You can mostly replicate this by renaming the source root so it no longer exists on disk.
  5. Running with --build-dir.
  6. Running with $RUST_BOOTSTRAP_CONFIG set in the environment and build-dir set in the file.

Originally posted by @jyn514 in #109055 (comment)

Activity

  1. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    on Mar 14, 2023
  2. added a commit that references this issue on Apr 6, 2023
  3. added a commit that references this issue on Apr 6, 2023
  4. added a commit that references this issue on Apr 6, 2023
  5. removed
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    on Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions