Repository navigation
Update from_raw_with_void_ptr to support types other than Box - #9700
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
This is a follow-up PR to #9690, btw. |
|
☔ The latest upstream changes (presumably #9541) made this pull request unmergeable. Please resolve the merge conflicts. |
|
That was quick! Thanks! Please rebase your branch on top of the latest master, instead of producing a merge commit. Let me know, if you need help with that. After that this is good to go. |
This PR updates the `from_raw_with_void_ptr` lint, which covered `Box::from_raw`, to also cover the `from_raw` static method of the `Rc`, `Arc`, `alloc::rc::Weak` and `alloc::sync::Weak` types. It also improves the description and error messages of this lint. --- changelog: [`from_raw_with_void_ptr`]: Now works with the `Rc`, `Arc`, `alloc::rc::Weak` and `alloc::sync::Weak` types.
109c1f5 to
e49cde7
Compare
Done. |
|
@bors r+ Awesome, thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This PR updates the
from_raw_with_void_ptrlint, which coveredBox::from_raw, to also cover thefrom_rawstatic method of theRc,Arc,alloc::rc::Weakandalloc::sync::Weaktypes.It also improves the description and error messages of this lint.
changelog: [
from_raw_with_void_ptr]: Now works with theRc,Arc,alloc::rc::Weakandalloc::sync::Weaktypes.